]> git.ipfire.org Git - thirdparty/gnutls.git/commitdiff
gnutls-cli-debug: avoid resource leak in saving DHE params
authorDaiki Ueno <ueno@gnu.org>
Mon, 15 Mar 2021 09:48:49 +0000 (10:48 +0100)
committerDaiki Ueno <ueno@gnu.org>
Mon, 15 Mar 2021 09:48:49 +0000 (10:48 +0100)
Signed-off-by: Daiki Ueno <ueno@gnu.org>
src/tests.c

index 067531bd8ecb9e65ad683c5c3516e13266309658..7d1530b14c66ffb302f0f3d6d392edf2e74185e1 100644 (file)
@@ -587,17 +587,26 @@ test_code_t test_dhe_group(gnutls_session_t session)
                        gnutls_datum_t p3;
                        
                        ret2 = gnutls_dh_params_init(&dhp);
-                       if (ret2 < 0)
+                       if (ret2 < 0) {
+                               fclose(fp);
                                return TEST_FAILED;
+                       }
 
                        ret2 = gnutls_dh_params_import_raw(dhp, &prime, &gen);
-                       if (ret2 < 0)
+                       if (ret2 < 0) {
+                               gnutls_dh_params_deinit(dhp);
+                               fclose(fp);
                                return TEST_FAILED;
+                       }
 
                        ret2 = gnutls_dh_params_export2_pkcs3(dhp, GNUTLS_X509_FMT_PEM, &p3);
-                       if (ret2 < 0)
+                       if (ret2 < 0) {
+                               gnutls_dh_params_deinit(dhp);
+                               fclose(fp);
                                return TEST_FAILED;
+                       }
 
+                       gnutls_dh_params_deinit(dhp);
                        fprintf(fp, "\n%s\n", p3.data);
                        gnutls_free(p3.data);
                }