3352. [bug] Ensure that learned server attributes timeout of the

                        adb cache. [RT #29856]

diff --git a/CHANGES b/CHANGES
index aa7d1f7c2a33609bc57150fed997781394312e8d..da08d55cf5bc7403f9249db455bd919766586df2 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+3352.  [bug]           Ensure that learned server attributes timeout of the
+                       adb cache. [RT #29856]
+
 3351.  [bug]           isc_mem_put and isc_mem_putanddetach didn't report
                        caller if either ISC_MEM_DEBUGSIZE or ISC_MEM_DEBUGCTX
                        memory debugging flags are set. [RT #30243]

diff --git a/lib/dns/adb.c b/lib/dns/adb.c
index d65d44a176d9f12ea6be160cf178c9aefad998a7..13432567f40068366681e5c1182e8321ac63e328 100644 (file)
--- a/lib/dns/adb.c
+++ b/lib/dns/adb.c
@@ -3939,8 +3939,10 @@ dns_adb_adjustsrtt(dns_adb_t *adb, dns_adbaddrinfo_t *addr,
        addr->entry->srtt = new_srtt;
        addr->srtt = new_srtt;
 
-       isc_stdtime_get(&now);
-       addr->entry->expires = now + ADB_ENTRY_WINDOW;
+       if (addr->entry->expires == 0) {
+               isc_stdtime_get(&now);
+               addr->entry->expires = now + ADB_ENTRY_WINDOW;
+       }
 
        UNLOCK(&adb->entrylocks[bucket]);
 }
@@ -3950,6 +3952,7 @@ dns_adb_changeflags(dns_adb_t *adb, dns_adbaddrinfo_t *addr,
                    unsigned int bits, unsigned int mask)
 {
        int bucket;
+       isc_stdtime_t now;
 
        REQUIRE(DNS_ADB_VALID(adb));
        REQUIRE(DNS_ADBADDRINFO_VALID(addr));
@@ -3958,6 +3961,11 @@ dns_adb_changeflags(dns_adb_t *adb, dns_adbaddrinfo_t *addr,
        LOCK(&adb->entrylocks[bucket]);
 
        addr->entry->flags = (addr->entry->flags & ~mask) | (bits & mask);
+       if (addr->entry->expires == 0) {
+               isc_stdtime_get(&now);
+               addr->entry->expires = now + ADB_ENTRY_WINDOW;
+       }
+
        /*
         * Note that we do not update the other bits in addr->flags with
         * the most recent values from addr->entry->flags.
@@ -4036,15 +4044,16 @@ dns_adb_freeaddrinfo(dns_adb_t *adb, dns_adbaddrinfo_t **addrp) {
        entry = addr->entry;
        REQUIRE(DNS_ADBENTRY_VALID(entry));
 
-       isc_stdtime_get(&now);
-
        *addrp = NULL;
        overmem = isc_mem_isovermem(adb->mctx);
 
        bucket = addr->entry->lock_bucket;
        LOCK(&adb->entrylocks[bucket]);
 
-       entry->expires = now + ADB_ENTRY_WINDOW;
+       if (entry->expires == 0) {
+               isc_stdtime_get(&now);
+               entry->expires = now + ADB_ENTRY_WINDOW;
+       }
 
        want_check_exit = dec_entry_refcnt(adb, overmem, entry, ISC_FALSE);