]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Silence Coverity CHECKED_RETURN warnings
authorMark Andrews <marka@isc.org>
Mon, 10 Feb 2020 20:44:21 +0000 (07:44 +1100)
committerMark Andrews <marka@isc.org>
Tue, 11 Feb 2020 13:02:08 +0000 (13:02 +0000)
CID 1458403 (#1 of 1): Unchecked return value (CHECKED_RETURN)
8. check_return: Calling isc_socket_recv without checking
return value (as is done elsewhere 14 out of 17 times).

121        isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);

CID 1458402 (#1 of 1): Unchecked return value (CHECKED_RETURN)
2. check_return: Calling isc_socket_recv without checking
return value (as is done elsewhere 14 out of 17 times).

149        isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);

CID 1458401 (#1 of 1): Unchecked return value (CHECKED_RETURN)
6. check_return: Calling isc_socket_recv without checking
return value (as is done elsewhere 14 out of 17 times).

226                isc_socket_recv(dev->newsocket, &region, 1,
227                                newtask, my_recv, event->ev_arg);

bin/tests/optional/sock_test.c

index f13a3ffe64c8077edb197dda18306ba4b612f719..4bd11e95ffb4895c7fd7a17ea53970a019a0a188 100644 (file)
@@ -118,7 +118,9 @@ my_recv(isc_task_t *task, isc_event_t *event) {
                       (int)dev->n, (char *)region.base);
        }
 
-       isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);
+       RUNTIME_CHECK(isc_socket_recv(sock, &dev->region, 1, task,
+                                     my_recv, event->ev_arg)
+                     == ISC_R_SUCCESS);
 
        isc_event_free(&event);
 }
@@ -146,7 +148,9 @@ my_http_get(isc_task_t *task, isc_event_t *event) {
                return;
        }
 
-       isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);
+       RUNTIME_CHECK(isc_socket_recv(sock, &dev->region, 1, task,
+                                     my_recv, event->ev_arg)
+                     == ISC_R_SUCCESS);
 
        isc_event_free(&event);
 }
@@ -223,8 +227,9 @@ my_listen(isc_task_t *task, isc_event_t *event) {
                newtask = NULL;
                RUNTIME_CHECK(isc_task_create(manager, 0, &newtask)
                              == ISC_R_SUCCESS);
-               isc_socket_recv(dev->newsocket, &region, 1,
-                               newtask, my_recv, event->ev_arg);
+               RUNTIME_CHECK(isc_socket_recv(dev->newsocket, &region, 1,
+                                             newtask, my_recv, event->ev_arg)
+                             == ISC_R_SUCCESS);
                isc_task_detach(&newtask);
        } else {
                printf("detaching from socket %p\n", event->ev_sender);