2067. [bug] 'rndc' could close the socket too early triggering

                        a INSIST under Windows. [RT #16317]

diff --git a/CHANGES b/CHANGES
index 1bb8367c4209b83bc5c3f8079d886f018f00c061..f6eb40b40260525caf7a9ad4072e57ab49ec4f3a 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+2067.  [bug]           'rndc' could close the socket too early triggering
+                       a INSIST under Windows. [RT #16317]
+
 2066.  [placeholder]   rt16300
 
 2065.  [bug]           libbind: probe for HPUX prototypes for

diff --git a/bin/rndc/rndc.c b/bin/rndc/rndc.c
index 5456de314bde1aed135991bd3749906231bf6088..819d8737e8d6f613502334eec896cf449758223f 100644 (file)
--- a/bin/rndc/rndc.c
+++ b/bin/rndc/rndc.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: rndc.c,v 1.112 2006/07/20 03:41:57 marka Exp $ */
+/* $Id: rndc.c,v 1.113 2006/08/04 02:55:37 marka Exp $ */
 
 /*! \file */
 
@@ -176,6 +176,11 @@ rndc_senddone(isc_task_t *task, isc_event_t *event) {
        if (sevent->result != ISC_R_SUCCESS)
                fatal("send failed: %s", isc_result_totext(sevent->result));
        isc_event_free(&event);
+       if (sends == 0 && recvs == 0) {
+               isc_socket_detach(&sock);
+               isc_task_shutdown(task);
+               RUNTIME_CHECK(isc_app_shutdown() == ISC_R_SUCCESS);
+       }
 }
 
 static void
@@ -228,9 +233,11 @@ rndc_recvdone(isc_task_t *task, isc_event_t *event) {
 
        isc_event_free(&event);
        isccc_sexpr_free(&response);
-       isc_socket_detach(&sock);
-       isc_task_shutdown(task);
-       RUNTIME_CHECK(isc_app_shutdown() == ISC_R_SUCCESS);
+       if (sends == 0 && recvs == 0) {
+               isc_socket_detach(&sock);
+               isc_task_shutdown(task);
+               RUNTIME_CHECK(isc_app_shutdown() == ISC_R_SUCCESS);
+       }
 }
 
 static void

diff --git a/lib/isc/win32/socket.c b/lib/isc/win32/socket.c
index f7f27d2c5e6b5a7f8d3acf0a58c75d92183d0714..15ae247cbcded12864758b5602f4839e54fa7da9 100644 (file)
--- a/lib/isc/win32/socket.c
+++ b/lib/isc/win32/socket.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: socket.c,v 1.44 2006/06/06 00:53:36 marka Exp $ */
+/* $Id: socket.c,v 1.45 2006/08/04 02:55:37 marka Exp $ */
 
 /* This code has been rewritten to take advantage of Windows Sockets
  * I/O Completion Ports and Events. I/O Completion Ports is ONLY
@@ -1711,14 +1711,15 @@ destroy_socket(isc_socket_t **sockp) {
        socket_log(sock, NULL, CREATION, isc_msgcat, ISC_MSGSET_SOCKET,
                   ISC_MSG_DESTROYING, "destroying socket %d", sock->fd);
 
+       LOCK(&manager->lock);
+
+       LOCK(&sock->lock);
+
        INSIST(ISC_LIST_EMPTY(sock->accept_list));
        INSIST(ISC_LIST_EMPTY(sock->recv_list));
        INSIST(ISC_LIST_EMPTY(sock->send_list));
        INSIST(sock->connect_ev == NULL);
 
-       LOCK(&manager->lock);
-
-       LOCK(&sock->lock);
        socket_close(sock);
        if (sock->pending_recv != 0 || sock->pending_send != 0 ||
            sock->pending_close != 0) {