s3:smbd: Initialize struct security_ace array

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/smbd/posix_acls.c:4599: var_decl: Declaring variable ""aces"" without initializer.
samba-4.20.0rc2/source3/smbd/posix_acls.c:4676: uninit_use_in_call: Using uninitialized value ""*aces"". Field ""aces->object"" is uninitialized when calling ""make_sec_acl"".
 4674|   	idx++;
 4675|
 4676|-> 	new_dacl = make_sec_acl(ctx,
 4677|   			NT4_ACL_REVISION,
 4678|   			idx,"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
index 38373e96aca4bafacab2f9ea7a22dfb75543a062..0f6a0d52e0192f17f7d061989bfea2e22b3299b0 100644 (file)
--- a/source3/smbd/posix_acls.c
+++ b/source3/smbd/posix_acls.c
@@ -4596,7 +4596,7 @@ static NTSTATUS make_default_acl_posix(TALLOC_CTX *ctx,
 {
        struct dom_sid owner_sid, group_sid;
        size_t size = 0;
-       struct security_ace aces[4];
+       struct security_ace aces[4] = {};
        uint32_t access_mask = 0;
        mode_t mode = psbuf->st_ex_mode;
        struct security_acl *new_dacl = NULL;