Stop xmlFreeTextWriter being called twice

xmlFreeTextWriter could be called twice if xmlDocDumpFormatMemoryEnc
failed.

(cherry picked from commit b5cf54252ae6d7fb03743210be80949b620f7945)

diff --git a/bin/named/statschannel.c b/bin/named/statschannel.c
index 52ae72f127acb2a8ab45a0dfad978c45e070d6c1..34f459a119eb42014a75d7040ab40dfc55522a18 100644 (file)
--- a/bin/named/statschannel.c
+++ b/bin/named/statschannel.c
@@ -2407,12 +2407,12 @@ generatexml(named_server_t *server, uint32_t flags, int *buflen,
        TRY0(xmlTextWriterEndElement(writer)); /* /statistics */
        TRY0(xmlTextWriterEndDocument(writer));
 
-       xmlFreeTextWriter(writer);
-
        xmlDocDumpFormatMemoryEnc(doc, buf, buflen, "UTF-8", 0);
        if (*buf == NULL) {
                goto error;
        }
+
+       xmlFreeTextWriter(writer);
        xmlFreeDoc(doc);
        return (ISC_R_SUCCESS);