]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
pkcs7: fix NULL contents dereference in PKCS7_ctrl
authorWeidong Wang <kenazcharisma@gmail.com>
Tue, 10 Mar 2026 17:08:35 +0000 (12:08 -0500)
committerNeil Horman <nhorman@openssl.org>
Tue, 17 Mar 2026 17:04:51 +0000 (13:04 -0400)
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
MergeDate: Tue Mar 17 17:01:49 2026
(Merged from https://github.com/openssl/openssl/pull/30351)

(cherry picked from commit b43e441550b2d1f1a99e42807f08329666934e63)

crypto/pkcs7/pk7_lib.c

index 675c694e66cd6778c4a432629a04c276bd28037c..372144b00caea65b9a53a8cc330b440054ea17f1 100644 (file)
@@ -48,7 +48,8 @@ long PKCS7_ctrl(PKCS7 *p7, int cmd, long larg, char *parg)
         break;
     case PKCS7_OP_GET_DETACHED_SIGNATURE:
         if (nid == NID_pkcs7_signed) {
-            if (p7->d.sign == NULL || p7->d.sign->contents->d.ptr == NULL)
+            if (p7->d.sign == NULL || p7->d.sign->contents == NULL
+                    || p7->d.sign->contents->d.ptr == NULL)
                 ret = 1;
             else
                 ret = 0;