]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
insane: appendVarFlags must be preceded by a whitespace
authorShotaro Uchida <fantom.jac@gmail.com>
Fri, 27 Mar 2026 23:15:18 +0000 (16:15 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 30 Mar 2026 16:51:25 +0000 (17:51 +0100)
appendVarFlags is not automatically adding a whitespace, user must add a
white space before the value to be added. Current usage may break
INSANE_SKIP:${PN} vardeps flag value by adding QAPATHTEST functions
immediately without a whitespace. e.g. It will become something like
INSANE_SKIP:${PN}package_qa_check_shebang_size

[RP: Simplify string slightly]
Signed-off-by: Shotaro Uchida <suchida@uaudio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes-global/insane.bbclass

index 8bbe5bb19a92d530d9e8aeb8f45e5d6e495c26e9..feddfe033596e9baf04e6991aa8e5c48f1be17f8 100644 (file)
@@ -1207,7 +1207,7 @@ python() {
     funcs = d.getVarFlags("QAPATHTEST")
     funcs.update(d.getVarFlags("QAPKGTEST"))
     funcs.update(d.getVarFlags("QARECIPETEST"))
-    d.appendVarFlag("do_package_qa", "vardeps", " ".join(funcs.values()))
+    d.appendVarFlag("do_package_qa", "vardeps", " " + " ".join(funcs.values()))
 }
 
 SSTATETASKS += "do_package_qa"