]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
scsi: change buf_size to unsigned int in scsi_SG_IO()
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 15 Apr 2026 23:29:05 +0000 (19:29 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 8 May 2026 14:37:18 +0000 (16:37 +0200)
SG_IO supports an unsigned int dxfer_len value. Existing callers use
less than 256 bytes, so scsi_SG_IO()'s uint8_t buf_size type was
sufficient. The next patch will use a larger value, so update the type.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Link: https://lore.kernel.org/r/20260415232906.212349-2-stefanha@redhat.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/scsi-generic.c
include/hw/scsi/scsi.h

index a2316a5266efd3c0fdaf17f6f5a42087cdacff7d..e629b1756b0aa2698a214fdd482c81425894bbb3 100644 (file)
@@ -774,7 +774,7 @@ static int read_naa_id(const uint8_t *p, uint64_t *p_wwn)
 }
 
 int scsi_SG_IO(BlockBackend *blk, int direction, uint8_t *cmd,
-               uint8_t cmd_size, uint8_t *buf, uint8_t buf_size,
+               uint8_t cmd_size, uint8_t *buf, unsigned int buf_size,
                uint32_t timeout, Error **errp)
 {
     sg_io_hdr_t io_header;
index a3e246dbd92e55b57e1d4339797337cbb7d1c753..5f83e58d1d0073a88092a6bca7663d993e7044c6 100644 (file)
@@ -247,7 +247,8 @@ void scsi_device_unit_attention_reported(SCSIDevice *dev);
 void scsi_generic_read_device_inquiry(SCSIDevice *dev);
 int scsi_device_get_sense(SCSIDevice *dev, uint8_t *buf, int len, bool fixed);
 int scsi_SG_IO(BlockBackend *blk, int direction, uint8_t *cmd, uint8_t cmd_size,
-               uint8_t *buf, uint8_t buf_size, uint32_t timeout, Error **errp);
+               uint8_t *buf, unsigned int buf_size, uint32_t timeout,
+               Error **errp);
 SCSIDevice *scsi_device_find(SCSIBus *bus, int channel, int target, int lun);
 SCSIDevice *scsi_device_get(SCSIBus *bus, int channel, int target, int lun);