]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
authorFrank Lichtenheld <frank@lichtenheld.com>
Sat, 4 Apr 2026 20:35:19 +0000 (22:35 +0200)
committerGert Doering <gert@greenie.muc.de>
Sun, 5 Apr 2026 10:17:14 +0000 (12:17 +0200)
Increase the integer, not the pointer.

Found by cppcheck.

Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
Message-Id: <20260404203525.30790-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36476.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 4494a343967e9cd0fcf32f167b22706512c8c68c)

src/openvpnmsica/openvpnmsica.c

index a145b6475f59ae652f95c548e3b22a4815fac1e1..fdb610ca76bd9966804b8704aac05807afb2b156 100644 (file)
@@ -613,7 +613,7 @@ schedule_adapter_delete(_Inout_ struct msica_arg_seq *seq,
                 msica_arg_seq_add_tail(seq, szArgument);
             }
 
-            iTicks += MSICA_ADAPTER_TICK_SIZE;
+            *iTicks += MSICA_ADAPTER_TICK_SIZE;
             break; /* Adapter names are unique. There should be no other adapter with this name. */
         }
     }