Bug 2057695: fix precedence issues with negation (#231)

r=justdave

Co-authored-by: Frédéric Buclin <LpSolit@gmail.com>

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 4af294071847c1dabd7b60e4af7b8fbe3fed0e7e..81d43bb0e0f4e53badfc577bfcef97ccaccf66e9 100644 (file)
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -587,7 +587,7 @@ sub possible_duplicates {
   my $products   = $params->{products} || [];
   my $limit      = $params->{limit} || MAX_POSSIBLE_DUPLICATES;
   $limit    = MAX_POSSIBLE_DUPLICATES if $limit > MAX_POSSIBLE_DUPLICATES;
-  $products = [$products]             if !ref($products) eq 'ARRAY';
+  $products = [$products]             if ref($products) ne 'ARRAY';
 
   my $orig_limit = $limit;
   detaint_natural($limit)

diff --git a/Bugzilla/Template/Plugin/Hook.pm b/Bugzilla/Template/Plugin/Hook.pm
index e315ab79ec7e8985150d422b25f001d354247f6e..f937a8f7c8d6baf740ceb511b41f93a82588d7c3 100644 (file)
--- a/Bugzilla/Template/Plugin/Hook.pm
+++ b/Bugzilla/Template/Plugin/Hook.pm
@@ -33,7 +33,7 @@ sub process {
   $template ||= $context->stash->{component}->{name};
 
   # sanity check:
-  if (!$template =~ /[\w\.\/\-_\\]+/) {
+  if ($template !~ /[\w\.\/\-_\\]+/) {
     ThrowCodeError('template_invalid', {name => $template});
   }