]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pthreadpool: reset monitor_fd after calling tevent_fd_set_auto_close()
authorStefan Metzmacher <metze@samba.org>
Tue, 31 Jul 2018 07:42:40 +0000 (09:42 +0200)
committerVolker Lendecke <vl@samba.org>
Tue, 31 Jul 2018 09:26:16 +0000 (11:26 +0200)
This tries to convince Coverity that we don't have a resource leak:

CID 1438157:    (RESOURCE_LEAK)
Handle variable "monitor_fd" going out of scope leaks the handle.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
lib/pthreadpool/pthreadpool_tevent.c

index 7088202d97cae8751de73b39a119622207aa6e0e..12148f18123b59eb273eed3fad62ca0807bd9f73 100644 (file)
@@ -719,6 +719,7 @@ static int pthreadpool_tevent_register_ev(
                        return ENOMEM;
                }
                tevent_fd_set_auto_close(glue->fde);
+               monitor_fd = -1;
        }
 
        /*