]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
minikconf: fix type mismatch in do_declaration
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 24 Apr 2026 08:17:41 +0000 (10:17 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 30 Apr 2026 13:50:18 +0000 (15:50 +0200)
The set stores strings, not Vars.  Because of this the duplicate
definition check did not work.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
scripts/minikconf.py

index 668de577d09738b7ef0a016338638b55a8fe548c..2656d3649205da81b306e01efaeb054d8b86d560 100644 (file)
@@ -262,8 +262,8 @@ class KconfigData:
     # semantic actions -------------
 
     def do_declaration(self, var):
-        if (var in self.defined_vars):
-            raise KconfigDataError('variable "' + var + '" defined twice')
+        if var.name in self.defined_vars:
+            raise KconfigDataError('variable "%s" defined twice' % var.name)
 
         self.defined_vars.add(var.name)