1637. [bug] Node reference leak on error in addnoqname().

diff --git a/CHANGES b/CHANGES
index 0cf4d7baade82cab6145be264326446ded0f658b..b1c1f1769fef8282bffab6adf6718e7b47654ee8 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+1637.  [bug]           Node reference leak on error in addnoqname().
+
 1636.  [bug]           The dump done callback could get ISC_R_SUCCESS even if
                        a error had occured.  The database version no longer
                        matched the version of the database that was dumped.

diff --git a/lib/dns/rbtdb.c b/lib/dns/rbtdb.c
index d0693fd6bde2c8a6fb44b766b47babc87c1978c5..0c85c8238c251b17983b925cb48a8dde817c8e2e 100644 (file)
--- a/lib/dns/rbtdb.c
+++ b/lib/dns/rbtdb.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: rbtdb.c,v 1.197 2004/05/05 01:32:58 marka Exp $ */
+/* $Id: rbtdb.c,v 1.198 2004/05/14 01:05:53 marka Exp $ */
 
 /*
  * Principal Author: Bob Halley
@@ -3178,6 +3178,7 @@ attachnode(dns_db_t *db, dns_dbnode_t *source, dns_dbnode_t **targetp) {
        dns_rbtnode_t *node = (dns_rbtnode_t *)source;
 
        REQUIRE(VALID_RBTDB(rbtdb));
+       REQUIRE(targetp != NULL && *targetp == NULL);
 
        LOCK(&rbtdb->node_locks[node->locknum].lock);
        INSIST(node->references > 0);
@@ -4093,8 +4094,10 @@ addnoqname(dns_rbtdb_t *rbtdb, rdatasetheader_t *newheader,
        RUNTIME_CHECK(result == ISC_R_SUCCESS);
 
        noqname = isc_mem_get(mctx, sizeof(*noqname));
-       if (noqname == NULL)
-               return (ISC_R_NOMEMORY);
+       if (noqname == NULL) {
+               result = ISC_R_NOMEMORY;
+               goto cleanup;
+       }
        dns_name_init(&noqname->name, NULL);
        noqname->nsec = NULL;
        noqname->nsecsig = NULL;
@@ -4115,6 +4118,8 @@ addnoqname(dns_rbtdb_t *rbtdb, rdatasetheader_t *newheader,
        return (ISC_R_SUCCESS);
 
 cleanup:
+       dns_rdataset_disassociate(&nsec);
+       dns_rdataset_disassociate(&nsecsig);
        free_noqname(mctx, &noqname);
        return(result);
 }
@@ -4957,7 +4962,7 @@ static void
 rdataset_clone(dns_rdataset_t *source, dns_rdataset_t *target) {
        dns_db_t *db = source->private1;
        dns_dbnode_t *node = source->private2;
-       dns_dbnode_t *cloned_node;
+       dns_dbnode_t *cloned_node = NULL;
 
        attachnode(db, node, &cloned_node);
        *target = *source;
@@ -4988,9 +4993,8 @@ rdataset_getnoqname(dns_rdataset_t *rdataset, dns_name_t *name,
        dns_dbnode_t *cloned_node;
        struct noqname *noqname = rdataset->private6;
 
+       cloned_node = NULL;
        attachnode(db, node, &cloned_node);
-       attachnode(db, node, &cloned_node);
-
        nsec->methods = &rdataset_methods;
        nsec->rdclass = db->rdclass;
        nsec->type = dns_rdatatype_nsec;
@@ -5004,6 +5008,8 @@ rdataset_getnoqname(dns_rdataset_t *rdataset, dns_name_t *name,
        nsec->private5 = NULL;
        nsec->private6 = NULL;
 
+       cloned_node = NULL;
+       attachnode(db, node, &cloned_node);
        nsecsig->methods = &rdataset_methods;
        nsecsig->rdclass = db->rdclass;
        nsecsig->type = dns_rdatatype_rrsig;
@@ -5022,7 +5028,6 @@ rdataset_getnoqname(dns_rdataset_t *rdataset, dns_name_t *name,
        return (ISC_R_SUCCESS);
 }
 
-
 /*
  * Rdataset Iterator Methods
  */