]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: fbtft: fix unchecked write return value in fb_agm1264k-fl
authorArtem Lytkin <iprintercanon@gmail.com>
Sat, 7 Feb 2026 22:05:23 +0000 (22:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Feb 2026 14:38:15 +0000 (15:38 +0100)
The second call to par->fbtftops.write() does not capture the return
value, so the subsequent error check tests a stale value from the
first write call. Add the missing assignment so the error check
applies to the correct write operation.

Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Link: https://patch.msgid.link/20260207220523.3816-1-iprintercanon@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fbtft/fb_agm1264k-fl.c

index af2dbebefc72beabff6c311ceb0472e47517d68e..6fc8f4e9c814d88c361d84876827e057bd46fa22 100644 (file)
@@ -376,7 +376,7 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 
                        /* write bitmap */
                        gpiod_set_value(par->RS, 1); /* RS->1 (data mode) */
-                       par->fbtftops.write(par, buf, len);
+                       ret = par->fbtftops.write(par, buf, len);
                        if (ret < 0)
                                dev_err(par->info->device,
                                        "write failed and returned: %d\n",