]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: mention interface name in polkit details
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 28 May 2026 16:42:14 +0000 (01:42 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 28 May 2026 19:34:18 +0000 (04:34 +0900)
Closes #42274.

src/network/networkd-link-bus.c
src/network/networkd-link-varlink.c

index 53ac080a4724706df3877d29c91810361422bbe0..454db15fdfea06f52ac03a0dce8fcfd66e60a680 100644 (file)
@@ -88,7 +88,7 @@ int bus_link_method_set_ntp_servers(sd_bus_message *message, void *userdata, sd_
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-ntp-servers",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -124,7 +124,7 @@ static int bus_link_method_set_dns_servers_internal(sd_bus_message *message, voi
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-dns-servers",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -225,7 +225,7 @@ int bus_link_method_set_domains(sd_bus_message *message, void *userdata, sd_bus_
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-domains",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -262,7 +262,7 @@ int bus_link_method_set_default_route(sd_bus_message *message, void *userdata, s
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-default-route",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -308,7 +308,7 @@ int bus_link_method_set_llmnr(sd_bus_message *message, void *userdata, sd_bus_er
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-llmnr",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -354,7 +354,7 @@ int bus_link_method_set_mdns(sd_bus_message *message, void *userdata, sd_bus_err
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-mdns",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -400,7 +400,7 @@ int bus_link_method_set_dns_over_tls(sd_bus_message *message, void *userdata, sd
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-dns-over-tls",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -446,7 +446,7 @@ int bus_link_method_set_dnssec(sd_bus_message *message, void *userdata, sd_bus_e
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-dnssec",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -504,7 +504,7 @@ int bus_link_method_set_dnssec_negative_trust_anchors(sd_bus_message *message, v
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.set-dnssec-negative-trust-anchors",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -534,7 +534,7 @@ int bus_link_method_revert_ntp(sd_bus_message *message, void *userdata, sd_bus_e
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.revert-ntp",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry, error);
         if (r < 0)
                 return r;
@@ -563,7 +563,7 @@ int bus_link_method_revert_dns(sd_bus_message *message, void *userdata, sd_bus_e
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.revert-dns",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -592,7 +592,7 @@ int bus_link_method_force_renew(sd_bus_message *message, void *userdata, sd_bus_
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.forcerenew",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -621,7 +621,7 @@ int bus_link_method_renew(sd_bus_message *message, void *userdata, sd_bus_error
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.renew",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
@@ -645,7 +645,7 @@ int bus_link_method_reconfigure(sd_bus_message *message, void *userdata, sd_bus_
         r = bus_verify_polkit_async(
                         message,
                         "org.freedesktop.network1.reconfigure",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", l->ifname),
                         &l->manager->polkit_registry,
                         error);
         if (r < 0)
index c802c7fb43f68abd34222095f5e0f093bd68058c..02d25a757e0b6c8261f67381e9f7a6f06d0efc4f 100644 (file)
@@ -104,7 +104,9 @@ static int vl_method_link_up_or_down(sd_varlink *vlink, sd_json_variant *paramet
                         vlink,
                         manager->bus,
                         "org.freedesktop.network1.manage-links",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE(
+                                        "interface", link->ifname,
+                                        "verb", up ? "up" : "down"),
                         &manager->polkit_registry);
         if (r <= 0)
                 return r;
@@ -143,7 +145,7 @@ int vl_method_link_renew(sd_varlink *vlink, sd_json_variant *parameters, sd_varl
                         vlink,
                         manager->bus,
                         "org.freedesktop.network1.renew",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", link->ifname),
                         &manager->polkit_registry);
         if (r <= 0)
                 return r;
@@ -173,7 +175,7 @@ int vl_method_link_force_renew(sd_varlink *vlink, sd_json_variant *parameters, s
                         vlink,
                         manager->bus,
                         "org.freedesktop.network1.forcerenew",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", link->ifname),
                         &manager->polkit_registry);
         if (r <= 0)
                 return r;
@@ -202,7 +204,7 @@ int vl_method_link_reconfigure(sd_varlink *vlink, sd_json_variant *parameters, s
                         vlink,
                         manager->bus,
                         "org.freedesktop.network1.reconfigure",
-                        /* details= */ NULL,
+                        (const char**) STRV_MAKE("interface", link->ifname),
                         &manager->polkit_registry);
         if (r <= 0)
                 return r;