send_mail: fix memory leak in newsmtp()

The newsmtp() function allocates memory for relayhost and smtphelo
but never frees them.

- relayhost: allocated via xstrdup() or ctrlvalue()
- smtphelo: allocated via ctrlvalue() or hostnamestr()

Both allocations are only used temporarily to call initsmtp(), which
copies the values it needs. So, just free() both.

Fixes: 48418b61 ("mlmmj-bounce: use send_mail directly and stop executing mlmmj-send")
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

diff --git a/src/send_mail.c b/src/send_mail.c
index a83b086772b0fc893181b08fa2dac187f0aa02aa..948aa98483b0b5369e6903a263dd4920aa50d39d 100644 (file)
--- a/src/send_mail.c
+++ b/src/send_mail.c
@@ -367,8 +367,13 @@ newsmtp(struct ml *ml, const char *rhost)
        smtphelo = ctrlvalue(ml->ctrlfd, "smtphelo");
        if (smtphelo == NULL)
                smtphelo = hostnamestr();
-       if (initsmtp(&sockfd, relayhost, smtpport, smtphelo) != 0)
+       if (initsmtp(&sockfd, relayhost, smtpport, smtphelo) != 0) {
+               free(relayhost);
+               free(smtphelo);
                return (-1);
+       }
+       free(relayhost);
+       free(smtphelo);
        return (sockfd);
 }