]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
kernel: pse-pd: auto-select kmod-pse-pd from AddDepends helper
authorJonas Jelonek <jelonek.jonas@gmail.com>
Tue, 19 May 2026 12:32:52 +0000 (12:32 +0000)
committerRobert Marko <robimarko@gmail.com>
Wed, 20 May 2026 08:38:35 +0000 (10:38 +0200)
The AddDepends/pse-pd helper appended kmod-pse-pd to DEPENDS without the
'+' prefix, making it a hard dependency rather than an auto-selecting one.
This breaks pulling any PSE controller driver (kmod-pse-pd692x0,
kmod-pse-si3474, kmod-pse-tps23881, kmod-pse-regulator, ...) in via a
device's DEVICE_PACKAGES: the kmod itself is auto-selected, but the
unsatisfied hard dep on kmod-pse-pd silently drops it from .config.

Prefix the kmod-pse-pd entry with '+' so it auto-selects, matching how
the other deps in the same file (kmod-i2c-core, etc.) are expressed. The
helper is the right place to fix this; every PSE controller driver routes
through it.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/23449
Signed-off-by: Robert Marko <robimarko@gmail.com>
package/kernel/linux/modules/pse-pd.mk

index 44adb182973c15696d7cb6ad999e06711c6522e1..fb26e5fca39b7507e8a8280a4b979623e4433b85 100644 (file)
@@ -22,7 +22,7 @@ $(eval $(call KernelPackage,pse-pd))
 
 define AddDepends/pse-pd
   SUBMENU:=$(PSE_MENU)
-  DEPENDS+=kmod-pse-pd $(1)
+  DEPENDS+=+kmod-pse-pd $(1)
 endef
 
 define KernelPackage/pse-regulator