]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pmdomain: imx: fix OF node refcount
authorBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Thu, 21 May 2026 08:36:27 +0000 (10:36 +0200)
committerUlf Hansson <ulfh@kernel.org>
Wed, 3 Jun 2026 09:49:37 +0000 (11:49 +0200)
for_each_child_of_node_scoped() decrements the reference count of the
nod after each iteration. Assigning it without incrementing the refcount
to a dynamically allocated platform device will result in a double put
in platform_device_release(). Add the missing call to of_node_get().

Cc: stable@vger.kernel.org
Fixes: 3e4d109ee8fc ("pmdomain: imx: gpc: Simplify with scoped for each OF child loop")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Ulf Hansson <ulfh@kernel.org>
drivers/pmdomain/imx/gpc.c

index de695f1944ab31de3d37ce8000d0c577579d64f9..42e50c9b4fb9ffb96a20a462d4eb5168942a893c 100644 (file)
@@ -487,7 +487,7 @@ static int imx_gpc_probe(struct platform_device *pdev)
                        domain->ipg_rate_mhz = ipg_rate_mhz;
 
                        pd_pdev->dev.parent = &pdev->dev;
-                       pd_pdev->dev.of_node = np;
+                       pd_pdev->dev.of_node = of_node_get(np);
                        pd_pdev->dev.fwnode = of_fwnode_handle(np);
 
                        ret = platform_device_add(pd_pdev);