]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
smb: smbdirect: divide, not multiply, milliseconds by 1000
authorAlexander A. Klimov <grandmaster@al2klimov.de>
Wed, 20 May 2026 18:03:58 +0000 (20:03 +0200)
committerSteve French <stfrench@microsoft.com>
Thu, 21 May 2026 14:29:49 +0000 (09:29 -0500)
Unless smbdirect_connection_legacy_debug_proc_show()
wants to debug-log keep_alive_interval as microseconds,
a magnitude higher precision than available by the way,
keepalive_interval_msec should not be multiplied by 1000.

Fixes: cc55f65dd352 ("smb: client: make use of common smbdirect_socket_parameters")
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/smbdirect/debug.c

index 05ba7c8d165eec5370d7e11bbe66daf541b182a5..3445843445bff96c779c4af5053c3571ac11f853 100644 (file)
@@ -40,7 +40,7 @@ void smbdirect_connection_legacy_debug_proc_show(struct smbdirect_socket *sc,
 
        seq_puts(m, "\n");
        seq_printf(m, "Conn keep_alive_interval: %u ",
-                  sp->keepalive_interval_msec * 1000);
+                  sp->keepalive_interval_msec / 1000);
        seq_printf(m, "max_readwrite_size: %u rdma_readwrite_threshold: %u",
                   sp->max_read_write_size,
                   rdma_readwrite_threshold);