GDB: testsuite: reverse: Don't return value from top-level (manual)

This patch manually changes "return -1" statements that weren't caught
by the sed command.  It also changes a few "return 0" statements.

These return statements fall into one of these criteria:

- misaligned line, which is then fixed by this patch;
- return at top level but inside block such as with_test_prefix,
  foreach_with_prefix, with_timeout_factor, gdb_test_multiple.

Approved-By: Tom Tromey <tom@tromey.com>

diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp
index 19ebebf6a1260b6d7fabbeca5a721f8fd82e386a..0432dd47cc0831da40dcb5c0167088d190eb061e 100644 (file)
--- a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp
+++ b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp
@@ -49,7 +49,7 @@ if { [prepare_for_testing "failed to prepare" "$testfile" $srcfile] } {
 }
 
 if {![runto_main]} {
-    return 0
+    return
 }
 
 if {[supports_process_record]} {

diff --git a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp
index dd36528eb3efb43d7ff9f583fb6f4fa24dfc88ff..76febe312f583a6e2cb6288ec117b83e33979e03 100644 (file)
--- a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp
+++ b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp
@@ -133,7 +133,7 @@ foreach_with_prefix column_info_flag {column-info no-column-info} {
 
     if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
             $options]} {
-       return -1
+       return
    }
 
     run_tests

diff --git a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp
index dc1308861e2c68a6103fa9065985f3345ce36e41..3ed1d7e6fae26f7eb4c2b2cc8039e559e49657f6 100644 (file)
--- a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp
@@ -64,7 +64,7 @@ gdb_test_multiple "continue" $test {
     }
     -re " Illegal instruction.*\r\n$gdb_prompt $" {
        untested i386-sse-reverse
-       return -1
+       return
     }
 }
 
@@ -590,7 +590,7 @@ gdb_test_multiple "continue" $test {
     }
     -re " Illegal instruction.*\r\n$gdb_prompt $" {
        untested i386-ssse3-reverse
-       return -1
+       return
     }
 }
 
@@ -666,7 +666,7 @@ gdb_test_multiple "continue" $test {
     }
     -re " Illegal instruction.*\r\n$gdb_prompt $" {
        untested i386-sse4-reverse
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp
index ad8009b415a9c1d5eafc565f2d532d154becde6c..edf6ec081cdfbc9ba876c1827fa01e5ab331cf7a 100644 (file)
--- a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp
+++ b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp
@@ -46,7 +46,7 @@ proc test_print { has_history level test_name } {
 }
 
 if { ![runto_main] } {
-    return 0
+    return
 }
 
 #confirm that GDB doesn't go crazy if recording isn't enabled

diff --git a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp
index d34fe130e8e51d79df0b1a748e85433cf3d0000c..b175774aee4f630a779063e5cc2d2af8c2ef15b8 100644 (file)
--- a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp
+++ b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp
@@ -49,7 +49,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
 }
 
 if {![runto_main]} {
-    return 0
+    return
 }
 
 if {[supports_process_record]} {

diff --git a/gdb/testsuite/gdb.reverse/sigall-precsave.exp b/gdb/testsuite/gdb.reverse/sigall-precsave.exp
index d8bc6dfaccfa0f4974513b75fc9e16a46b632376..5ce7de0ea1fe4254f9801175d1d12051edf02da0 100644 (file)
--- a/gdb/testsuite/gdb.reverse/sigall-precsave.exp
+++ b/gdb/testsuite/gdb.reverse/sigall-precsave.exp
@@ -258,7 +258,7 @@ gdb_test_multiple "continue" "run to end of main" {
     }
     -wrap -re "Process record does not support instruction 0xfae64 at.*" {
        kfail "gdb/25038" $gdb_test_name
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.reverse/sigall-reverse.exp b/gdb/testsuite/gdb.reverse/sigall-reverse.exp
index 2dae1933d818bc63f502da07cbe74ab31b68ed32..45bb49ecfebe8204122ccdc39c8267869cb0e6e3 100644 (file)
--- a/gdb/testsuite/gdb.reverse/sigall-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/sigall-reverse.exp
@@ -239,7 +239,7 @@ with_test_prefix "sig-test-1" {
     foreach sig [lrange $signals 1 end] {
        test_one_sig $sig
        if { $record_instruction_kfail } {
-           return -1
+           return
        }
     }
 }

diff --git a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp
index 830292cd66692f5def08c26ce8a67cef19bef0ec..dfa8ac179f071a4fd57f19cb60dd5d80fe5630bd 100644 (file)
--- a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp
@@ -24,13 +24,13 @@ if {[info exists COMPILE]} {
                                      ${testfile}.c {debug optimize=-O2} \
                                      ${testfile}-nodebug.c {optimize=-O2} \
                                      ] == -1 } {
-       return -1
+       return
     }
 } else {
     require is_x86_64_m64_target
     if { [build_executable ${testfile}.exp ${testfile} \
              [list ${srcfile} ${srcfile2}] {}] == -1 } {
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.reverse/solib-precsave.exp b/gdb/testsuite/gdb.reverse/solib-precsave.exp
index ef3229c7492743f786b346a053369cca56ccef9c..cad30320048ba4c77b8a3acabff6676bbf8c6854 100644 (file)
--- a/gdb/testsuite/gdb.reverse/solib-precsave.exp
+++ b/gdb/testsuite/gdb.reverse/solib-precsave.exp
@@ -80,7 +80,7 @@ gdb_test_multiple "continue" "run to end of main" {
     }
     -wrap -re "Process record does not support instruction 0xfae64 at.*" {
        kfail "gdb/25038" $gdb_test_name
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.reverse/solib-reverse.exp b/gdb/testsuite/gdb.reverse/solib-reverse.exp
index c5a610fcb3912c86830bd8eb722929b9714092b5..b5f49fb72994f6179515df0c36cc08362e2358bd 100644 (file)
--- a/gdb/testsuite/gdb.reverse/solib-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/solib-reverse.exp
@@ -77,7 +77,7 @@ gdb_test_multiple "until $end_part_one" "run until end part one" {
     }
     -wrap -re "Process record does not support instruction 0xfae64 at.*" {
        kfail "gdb/25038" $gdb_test_name
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.reverse/until-precsave.exp b/gdb/testsuite/gdb.reverse/until-precsave.exp
index 411fc14fed274a09bb4b89e3f1907c012f19e566..075a87dc2d87085de172dc4a93a5124cfeded8e1 100644 (file)
--- a/gdb/testsuite/gdb.reverse/until-precsave.exp
+++ b/gdb/testsuite/gdb.reverse/until-precsave.exp
@@ -52,7 +52,7 @@ with_timeout_factor 20 {
        }
        -wrap -re "Process record does not support instruction 0xfae64 at.*" {
            kfail "gdb/25038" $gdb_test_name
-           return -1
+           return
        }
     }
 }

diff --git a/gdb/testsuite/gdb.reverse/until-reverse.exp b/gdb/testsuite/gdb.reverse/until-reverse.exp
index 74703223c64397ae0e280cfd87916837d001f8c4..19ec2fee6b0583d17c15db52fa1a0626309e0b4d 100644 (file)
--- a/gdb/testsuite/gdb.reverse/until-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/until-reverse.exp
@@ -53,7 +53,7 @@ gdb_test_multiple "advance factorial" "" {
     }
     -wrap -re "Process record does not support instruction 0xfae64 at.*" {
        kfail "gdb/25038" $gdb_test_name
-       return -1
+       return
     }
 }