[#3119] correct auto in for-loops

diff --git a/src/hooks/dhcp/lease_cmds/lease_cmds.cc b/src/hooks/dhcp/lease_cmds/lease_cmds.cc
index f4531aa6aac413c5baa4b62a044efe2ae782f65b..7fc90def1ee8ff6f8df2d14601fb484619c5afbd 100644 (file)
--- a/src/hooks/dhcp/lease_cmds/lease_cmds.cc
+++ b/src/hooks/dhcp/lease_cmds/lease_cmds.cc
@@ -1329,14 +1329,14 @@ LeaseCmdsImpl::leaseGetAllHandler(CalloutHandle& handle) {
                 if (v4) {
                     Lease4Collection leases =
                         LeaseMgrFactory::instance().getLeases4((*subnet_id)->intValue());
-                    for (auto lease : leases) {
+                    for (const auto& lease : leases) {
                         ElementPtr lease_json = lease->toElement();
                         leases_json->add(lease_json);
                     }
                 } else {
                     Lease6Collection leases =
                         LeaseMgrFactory::instance().getLeases6((*subnet_id)->intValue());
-                    for (auto lease : leases) {
+                    for (const auto& lease : leases) {
                         ElementPtr lease_json = lease->toElement();
                         leases_json->add(lease_json);
                     }
@@ -1347,13 +1347,13 @@ LeaseCmdsImpl::leaseGetAllHandler(CalloutHandle& handle) {
             // There is no 'subnets' argument so let's return all leases.
             if (v4) {
                 Lease4Collection leases = LeaseMgrFactory::instance().getLeases4();
-                for (auto lease : leases) {
+                for (const auto& lease : leases) {
                     ElementPtr lease_json = lease->toElement();
                     leases_json->add(lease_json);
                 }
             } else {
                 Lease6Collection leases = LeaseMgrFactory::instance().getLeases6();
-                for (auto lease : leases) {
+                for (const auto& lease : leases) {
                     ElementPtr lease_json = lease->toElement();
                     leases_json->add(lease_json);
                 }
@@ -1456,7 +1456,7 @@ LeaseCmdsImpl::leaseGetPageHandler(CalloutHandle& handle) {
                                                        LeasePageSize(page_limit_value));
 
             // Convert leases into JSON list.
-            for (auto lease : leases) {
+            for (const auto& lease : leases) {
                 ElementPtr lease_json = lease->toElement();
                 leases_json->add(lease_json);
             }
@@ -1467,7 +1467,7 @@ LeaseCmdsImpl::leaseGetPageHandler(CalloutHandle& handle) {
                 LeaseMgrFactory::instance().getLeases6(*from_address,
                                                        LeasePageSize(page_limit_value));
             // Convert leases into JSON list.
-            for (auto lease : leases) {
+            for (const auto& lease : leases) {
                 ElementPtr lease_json = lease->toElement();
                 leases_json->add(lease_json);
             }
@@ -1526,7 +1526,7 @@ LeaseCmdsImpl::leaseGetByHwAddressHandler(CalloutHandle& handle) {
         Lease4Collection leases =
             LeaseMgrFactory::instance().getLease4(hwaddr);
         ElementPtr leases_json = Element::createList();
-        for (auto lease : leases) {
+        for (const auto& lease : leases) {
             ElementPtr lease_json = lease->toElement();
             leases_json->add(lease_json);
         }
@@ -1576,7 +1576,7 @@ LeaseCmdsImpl::leaseGetByClientIdHandler(CalloutHandle& handle) {
         Lease4Collection leases =
             LeaseMgrFactory::instance().getLease4(*clientid);
         ElementPtr leases_json = Element::createList();
-        for (auto lease : leases) {
+        for (const auto& lease : leases) {
             ElementPtr lease_json = lease->toElement();
             leases_json->add(lease_json);
         }
@@ -1626,7 +1626,7 @@ LeaseCmdsImpl::leaseGetByDuidHandler(CalloutHandle& handle) {
         Lease6Collection leases =
             LeaseMgrFactory::instance().getLeases6(duid_);
         ElementPtr leases_json = Element::createList();
-        for (auto lease : leases) {
+        for (const auto& lease : leases) {
             ElementPtr lease_json = lease->toElement();
             leases_json->add(lease_json);
         }
@@ -1685,7 +1685,7 @@ LeaseCmdsImpl::leaseGetByHostnameHandler(CalloutHandle& handle) {
             Lease4Collection leases =
                 LeaseMgrFactory::instance().getLeases4(hostname_);
 
-            for (auto lease : leases) {
+            for (const auto& lease : leases) {
                 ElementPtr lease_json = lease->toElement();
                 leases_json->add(lease_json);
             }
@@ -1693,7 +1693,7 @@ LeaseCmdsImpl::leaseGetByHostnameHandler(CalloutHandle& handle) {
             Lease6Collection leases =
                 LeaseMgrFactory::instance().getLeases6(hostname_);
 
-            for (auto lease : leases) {
+            for (const auto& lease : leases) {
                 ElementPtr lease_json = lease->toElement();
                 leases_json->add(lease_json);
             }
@@ -1836,7 +1836,7 @@ LeaseCmdsImpl::lease6BulkApplyHandler(CalloutHandle& handle) {
             auto leases_list = deleted_leases->listValue();
 
             // Iterate over leases to be deleted.
-            for (auto lease_params : leases_list) {
+            for (const auto& lease_params : leases_list) {
                 // Parsing the lease may throw and it means that the lease
                 // information is malformed.
                 Parameters p = getParameters(true, lease_params);
@@ -1853,7 +1853,7 @@ LeaseCmdsImpl::lease6BulkApplyHandler(CalloutHandle& handle) {
 
             // Iterate over all leases.
             auto leases_list = leases->listValue();
-            for (auto lease_params : leases_list) {
+            for (const auto& lease_params : leases_list) {
 
                 Lease6Parser parser;
                 bool force_update;
@@ -1872,7 +1872,7 @@ LeaseCmdsImpl::lease6BulkApplyHandler(CalloutHandle& handle) {
         if (!parsed_deleted_list.empty()) {
 
             // Iterate over leases to be deleted.
-            for (auto lease_params_pair : parsed_deleted_list) {
+            for (const auto& lease_params_pair : parsed_deleted_list) {
 
                 // This part is outside of the try-catch because an exception
                 // indicates that the command is malformed.
@@ -1924,7 +1924,7 @@ LeaseCmdsImpl::lease6BulkApplyHandler(CalloutHandle& handle) {
             ConstSrvConfigPtr config = CfgMgr::instance().getCurrentCfg();
 
             // Iterate over all leases.
-            for (auto lease : parsed_leases_list) {
+            for (const auto& lease : parsed_leases_list) {
 
                 auto result = CONTROL_RESULT_SUCCESS;
                 std::ostringstream text;
@@ -2269,7 +2269,7 @@ LeaseCmdsImpl::lease4WipeHandler(CalloutHandle& handle) {
             const Subnet4Collection* subs = subnets->getAll();
 
             // Go over all subnets and wipe leases in each of them.
-            for (auto sub : *subs) {
+            for (const auto& sub : *subs) {
                 num += LeaseMgrFactory::instance().wipeLeases4(sub->getID());
                 ids << " " << sub->getID();
                 StatsMgr::instance().setValue(
@@ -2401,7 +2401,7 @@ LeaseCmdsImpl::lease6WipeHandler(CalloutHandle& handle) {
             const Subnet6Collection* subs = subnets->getAll();
 
             // Go over all subnets and wipe leases in each of them.
-            for (auto sub : *subs) {
+            for (const auto& sub : *subs) {
                 num += LeaseMgrFactory::instance().wipeLeases6(sub->getID());
                 ids << " " << sub->getID();
                 StatsMgr::instance().setValue(

diff --git a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc
index 020d1ee5fdfca2db295a00287d6ceee55272d68e..c89c1316cd28b16f560bfea26391b33f7c3c5499 100644 (file)
--- a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc
+++ b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc
@@ -1161,14 +1161,14 @@ public:
                                MySqlBinding::createTimestamp(subnet->getModificationTime()));
 
         // (Re)create pools.
-        for (auto pool : subnet->getPools(Lease::TYPE_V4)) {
+        for (const auto& pool : subnet->getPools(Lease::TYPE_V4)) {
             createPool4(server_selector, boost::dynamic_pointer_cast<Pool4>(pool),
                         subnet);
         }
 
         // (Re)create options.
         auto option_spaces = subnet->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = subnet->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1203,7 +1203,7 @@ public:
 
         uint64_t pool_id = mysql_insert_id(conn_.mysql_);
         auto option_spaces = pool->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = pool->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1798,7 +1798,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = shared_network->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = shared_network->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -2721,7 +2721,7 @@ public:
                                MySqlBinding::createTimestamp(client_class->getModificationTime()));
 
         // Iterate over the captured dependencies and try to insert them into the database.
-        for (auto dependency : dependencies) {
+        for (const auto& dependency : dependencies) {
             try {
                 MySqlBindingCollection in_dependency_bindings = {
                     MySqlBinding::createString(client_class->getName()),
@@ -2747,7 +2747,7 @@ public:
         if (client_class->getCfgOptionDef()) {
             auto option_defs = client_class->getCfgOptionDef()->getContainer();
             auto option_spaces = option_defs.getOptionSpaceNames();
-            for (auto option_space : option_spaces) {
+            for (const auto& option_space : option_spaces) {
                 OptionDefContainerPtr defs = option_defs.getItems(option_space);
                 for (auto def = defs->begin(); def != defs->end(); ++def) {
                     createUpdateOptionDef4(server_selector, *def, client_class->getName());
@@ -2757,7 +2757,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = client_class->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = client_class->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -2922,7 +2922,7 @@ public:
             }
 
             // Iterate over the configured DBs and instantiate them.
-            for (auto db : config_ctl->getConfigDatabases()) {
+            for (const auto& db : config_ctl->getConfigDatabases()) {
                 const std::string& access = db.getAccessString();
                 auto parameters = db.getParameters();
                 if (ConfigBackendDHCPv4Mgr::instance().delBackend(parameters["type"], access, true)) {

diff --git a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc
index d1f1b0b542c8d3349abe78f8be762d796ae79404..2f290faad705a1d7a3e43b95c8925c556a9e4f3f 100644 (file)
--- a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc
+++ b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc
@@ -1412,20 +1412,20 @@ public:
                                MySqlBinding::createTimestamp(subnet->getModificationTime()));
 
         // (Re)create pools.
-        for (auto pool : subnet->getPools(Lease::TYPE_NA)) {
+        for (const auto& pool : subnet->getPools(Lease::TYPE_NA)) {
             createPool6(server_selector, boost::dynamic_pointer_cast<Pool6>(pool),
                         subnet);
         }
 
         // (Re)create pd pools.
-        for (auto pd_pool : subnet->getPools(Lease::TYPE_PD)) {
+        for (const auto& pd_pool : subnet->getPools(Lease::TYPE_PD)) {
             createPdPool6(server_selector, boost::dynamic_pointer_cast<Pool6>(pd_pool),
                           subnet);
         }
 
         // (Re)create options.
         auto option_spaces = subnet->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = subnet->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1461,7 +1461,7 @@ public:
 
         uint64_t pool_id = mysql_insert_id(conn_.mysql_);
         auto option_spaces = pool->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = pool->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1512,7 +1512,7 @@ public:
 
         uint64_t pd_pool_id = mysql_insert_id(conn_.mysql_);
         auto option_spaces = pd_pool->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = pd_pool->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -2137,7 +2137,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = shared_network->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = shared_network->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -3148,7 +3148,7 @@ public:
                                MySqlBinding::createTimestamp(client_class->getModificationTime()));
 
         // Iterate over the captured dependencies and try to insert them into the database.
-        for (auto dependency : dependencies) {
+        for (const auto& dependency : dependencies) {
             try {
                 MySqlBindingCollection in_dependency_bindings = {
                     MySqlBinding::createString(client_class->getName()),
@@ -3174,7 +3174,7 @@ public:
         if (client_class->getCfgOptionDef()) {
             auto option_defs = client_class->getCfgOptionDef()->getContainer();
             auto option_spaces = option_defs.getOptionSpaceNames();
-            for (auto option_space : option_spaces) {
+            for (const auto& option_space : option_spaces) {
                 OptionDefContainerPtr defs = option_defs.getItems(option_space);
                 for (auto def = defs->begin(); def != defs->end(); ++def) {
                     createUpdateOptionDef6(server_selector, *def, client_class->getName());
@@ -3184,7 +3184,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = client_class->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = client_class->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -3349,7 +3349,7 @@ public:
             }
 
             // Iterate over the configured DBs and instantiate them.
-            for (auto db : config_ctl->getConfigDatabases()) {
+            for (const auto& db : config_ctl->getConfigDatabases()) {
                 const std::string& access = db.getAccessString();
                 auto parameters = db.getParameters();
                 if (ConfigBackendDHCPv6Mgr::instance().delBackend(parameters["type"], access, true)) {

diff --git a/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc b/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
index a3858e10f86ba7ae5519ebbd76fedcf8aba32247..4e7b77056f8b0571e4d3840baed9280d96e73a46 100644 (file)
--- a/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
+++ b/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
@@ -1001,14 +1001,14 @@ public:
                                server_selector, attach_bindings);
 
         // (Re)create pools.
-        for (auto pool : subnet->getPools(Lease::TYPE_V4)) {
+        for (const auto& pool : subnet->getPools(Lease::TYPE_V4)) {
             createPool4(server_selector, boost::dynamic_pointer_cast<Pool4>(pool),
                         subnet);
         }
 
         // (Re)create options.
         auto option_spaces = subnet->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = subnet->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1048,7 +1048,7 @@ public:
 
         // Add the pool's options.
         auto option_spaces = pool->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = pool->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1574,7 +1574,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = shared_network->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = shared_network->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -2522,7 +2522,7 @@ public:
                                server_selector, attach_bindings);
 
         // Iterate over the captured dependencies and try to insert them into the database.
-        for (auto dependency : dependencies) {
+        for (const auto& dependency : dependencies) {
             try {
                 PsqlBindArray in_dependency_bindings;
                 in_dependency_bindings.add(class_name);
@@ -2548,7 +2548,7 @@ public:
         if (client_class->getCfgOptionDef()) {
             auto option_defs = client_class->getCfgOptionDef()->getContainer();
             auto option_spaces = option_defs.getOptionSpaceNames();
-            for (auto option_space : option_spaces) {
+            for (const auto& option_space : option_spaces) {
                 OptionDefContainerPtr defs = option_defs.getItems(option_space);
                 for (auto def = defs->begin(); def != defs->end(); ++def) {
                     createUpdateOptionDef4(server_selector, *def, client_class->getName());
@@ -2558,7 +2558,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = client_class->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = client_class->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -2725,7 +2725,7 @@ public:
             }
 
             // Iterate over the configured DBs and instantiate them.
-            for (auto db : config_ctl->getConfigDatabases()) {
+            for (const auto& db : config_ctl->getConfigDatabases()) {
                 const std::string& access = db.getAccessString();
                 auto parameters = db.getParameters();
                 if (ConfigBackendDHCPv4Mgr::instance().delBackend(parameters["type"], access, true)) {

diff --git a/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp6.cc b/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp6.cc
index 01696d2f97cc18813fb928243208c1c269018776..06dff3f3e1e2d1e046d47010dafcf73f5c09fa23 100644 (file)
--- a/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp6.cc
+++ b/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp6.cc
@@ -1170,20 +1170,20 @@ public:
                                server_selector, attach_bindings);
 
         // (Re)create pools.
-        for (auto pool : subnet->getPools(Lease::TYPE_NA)) {
+        for (const auto& pool : subnet->getPools(Lease::TYPE_NA)) {
             createPool6(server_selector, boost::dynamic_pointer_cast<Pool6>(pool),
                         subnet);
         }
 
         // (Re)create pd pools.
-        for (auto pd_pool : subnet->getPools(Lease::TYPE_PD)) {
+        for (const auto& pd_pool : subnet->getPools(Lease::TYPE_PD)) {
             createPdPool6(server_selector, boost::dynamic_pointer_cast<Pool6>(pd_pool),
                           subnet);
         }
 
         // (Re)create options.
         auto option_spaces = subnet->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = subnet->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1223,7 +1223,7 @@ public:
 
         // Add the pool's options.
         auto option_spaces = pool->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = pool->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1277,7 +1277,7 @@ public:
 
         // Add the pool's options.
         auto option_spaces = pd_pool->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = pd_pool->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -1811,7 +1811,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = shared_network->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = shared_network->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -2844,7 +2844,7 @@ public:
                                server_selector, attach_bindings);
 
         // Iterate over the captured dependencies and try to insert them into the database.
-        for (auto dependency : dependencies) {
+        for (const auto& dependency : dependencies) {
             try {
                 PsqlBindArray in_dependency_bindings;
                 in_dependency_bindings.add(class_name);
@@ -2870,7 +2870,7 @@ public:
         if (client_class->getCfgOptionDef()) {
             auto option_defs = client_class->getCfgOptionDef()->getContainer();
             auto option_spaces = option_defs.getOptionSpaceNames();
-            for (auto option_space : option_spaces) {
+            for (const auto& option_space : option_spaces) {
                 OptionDefContainerPtr defs = option_defs.getItems(option_space);
                 for (auto def = defs->begin(); def != defs->end(); ++def) {
                     createUpdateOptionDef6(server_selector, *def, client_class->getName());
@@ -2880,7 +2880,7 @@ public:
 
         // (Re)create options.
         auto option_spaces = client_class->getCfgOption()->getOptionSpaceNames();
-        for (auto option_space : option_spaces) {
+        for (const auto& option_space : option_spaces) {
             OptionContainerPtr options = client_class->getCfgOption()->getAll(option_space);
             for (auto desc = options->begin(); desc != options->end(); ++desc) {
                 OptionDescriptorPtr desc_copy = OptionDescriptor::create(*desc);
@@ -3047,7 +3047,7 @@ public:
             }
 
             // Iterate over the configured DBs and instantiate them.
-            for (auto db : config_ctl->getConfigDatabases()) {
+            for (const auto& db : config_ctl->getConfigDatabases()) {
                 const std::string& access = db.getAccessString();
                 auto parameters = db.getParameters();
                 if (ConfigBackendDHCPv6Mgr::instance().delBackend(parameters["type"], access, true)) {

diff --git a/src/lib/dhcpsrv/memfile_lease_mgr.cc b/src/lib/dhcpsrv/memfile_lease_mgr.cc
index c104ff73e702728ff72950edd358287305591f0d..577f6943d3ec9bd59838674adf0cfd6958dbe744 100644 (file)
--- a/src/lib/dhcpsrv/memfile_lease_mgr.cc
+++ b/src/lib/dhcpsrv/memfile_lease_mgr.cc
@@ -3321,7 +3321,7 @@ Memfile_LeaseMgr::buildExtendedInfoTables6() {
     size_t modified = 0;
     size_t processed = 0;
 
-    for (auto lease : storage6_) {
+    for (const auto& lease : storage6_) {
         ++leases;
         try {
             if (upgradeLease6ExtendedInfo(lease, check)) {

diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.cc b/src/lib/dhcpsrv/mysql_lease_mgr.cc
index e6b4d443ece48435208ee1c59ed019226b0bff05..c33482b460dc7e83619f04813f96f9f38f8f59a9 100644 (file)
--- a/src/lib/dhcpsrv/mysql_lease_mgr.cc
+++ b/src/lib/dhcpsrv/mysql_lease_mgr.cc
@@ -4580,7 +4580,7 @@ MySqlLeaseMgr::upgradeExtendedInfo6(const LeasePageSize& page_size) {
 
         ++pages;
         start_addr = leases.back()->addr_;
-        for (auto lease : leases) {
+        for (const auto& lease : leases) {
             try {
                 bool modified = upgradeLease6ExtendedInfo(lease, check);
                 if (modified) {

diff --git a/src/lib/dhcpsrv/pgsql_lease_mgr.cc b/src/lib/dhcpsrv/pgsql_lease_mgr.cc
index 5f223953af1af91e69c98dea649caf99c94d484a..b4e7ff35a25454f0adb2455dfd1efdb7f3476b1d 100644 (file)
--- a/src/lib/dhcpsrv/pgsql_lease_mgr.cc
+++ b/src/lib/dhcpsrv/pgsql_lease_mgr.cc
@@ -3622,7 +3622,7 @@ PgSqlLeaseMgr::upgradeExtendedInfo6(const LeasePageSize& page_size) {
 
         ++pages;
         start_addr = leases.back()->addr_;
-        for (auto lease : leases) {
+        for (const auto& lease : leases) {
             try {
                 bool modified = upgradeLease6ExtendedInfo(lease, check);
                 if (modified) {