Fix copy-paste error in hash_record_extended()

The code failed to initialize the second isnull argument passed to
FunctionCallInvoke().  This is harmless for existing in-core extended
hash support functions, since FunctionCallInvoke() does not use the
value (note that all the in-core extended hash functions are strict),
examining only the argument values.  However, extension-provided
extended hash functions could be affected if they inspect
PG_ARGISNULL(1).

Oversight in 01e658fa74cb.

Author: Man Zeng <zengman@halodbtech.com>
Discussion: https://postgr.es/m/tencent_7818173C01E01836109848C3@qq.com
Backpatch-through: 14

diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c
index 1a71fdbc33f57749b8c5492a41f84ff1271a74de..469ed3df8e6258457ce7869816659dde5dae53bc 100644 (file)
--- a/src/backend/utils/adt/rowtypes.c
+++ b/src/backend/utils/adt/rowtypes.c
@@ -1995,7 +1995,7 @@ hash_record_extended(PG_FUNCTION_ARGS)
                        locfcinfo->args[0].value = values[i];
                        locfcinfo->args[0].isnull = false;
                        locfcinfo->args[1].value = Int64GetDatum(seed);
-                       locfcinfo->args[0].isnull = false;
+                       locfcinfo->args[1].isnull = false;
                        element_hash = DatumGetUInt64(FunctionCallInvoke(locfcinfo));
 
                        /* We don't expect hash support functions to return null */