]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
Bugfix for accidentally closing all accordion panels 4941/head
authorJakob Hilden <jakobhilden@gmail.com>
Wed, 9 Apr 2014 16:20:50 +0000 (18:20 +0200)
committerJakob Hilden <jakobhilden@gmail.com>
Wed, 9 Apr 2014 16:20:50 +0000 (18:20 +0200)
When multiple accordion panels are expanded/active (possbile when `multi_expand: true`) clicking on one of the the active panels would close **all** other panels instead of ony the current one.

js/foundation/foundation.accordion.js

index 21480b8faa60c7824e7aa37acc0e90d7a94827af..3e21303eb099e0f04a9042fdf2ccc18d15cba642 100644 (file)
             siblings = S('dd > .content', accordion),
             aunts = $('dd', accordion),
             settings = accordion.data(self.attr_name(true) + '-init'),
-            active_content = S('dd > .content.' + settings.active_class, accordion),
-            active_parent = S('dd.' + settings.active_class, accordion);
+            active_content = S('dd > .content.' + settings.active_class, accordion);
         e.preventDefault();
 
         if (! S(this).closest('dl').is(accordion)) { return; }
 
         if (settings.toggleable && target.is(active_content)) {
-          active_parent.toggleClass(settings.active_class, false);
+          target.parent('dd').toggleClass(settings.active_class, false);
           return target.toggleClass(settings.active_class, false);
         }