]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
Fixed .exit-off-canvas not closing 'overlap' menu 5501/head
authorregdoug <pierce.reginald@gmail.com>
Fri, 25 Jul 2014 22:31:21 +0000 (18:31 -0400)
committerregdoug <pierce.reginald@gmail.com>
Fri, 25 Jul 2014 22:31:21 +0000 (18:31 -0400)
Old (buggy) behavior:
---
When the menu open_type was set to 'overlap', the .exit-off-canvas
link had no effect.

Cause
---
The `.offcanvas-overlap .exit-off-canvas` selector was missing. A
selector of `.offcanvas-overlap .exit-offcanvas-menu` was where
the `.offcanvas-overlap .exit-off-canvas` selector should have been

Fix
---
- Fix selector in scss/foundation/components/_offcanvas.scss
- No documentation changes are necessary because it now conforms
  to the documentation.  The string "exit-offcanvas-menu" is not
  found anywhere else in the repository.

scss/foundation/components/_offcanvas.scss

index 5242e1c7454c95eb88115305b313fbb4b173790e..b5bc451b6735a4b75e68a1bc3d3ac570cbcad181 100755 (executable)
@@ -150,7 +150,7 @@ $menu-slide: "transform 500ms ease" !default;
   height: $tabbar-height;
   line-height: $tabbar-line-height;
 
-  // make sure it's below the .exit-offcanvas link
+  // make sure it's below the .exit-off-canvas link
   position: relative;
   // z-index: 999;
 
@@ -338,10 +338,7 @@ $menu-slide: "transform 500ms ease" !default;
         transform: none;
         z-index: 1003;
       }
-      .exit-offcanvas-menu {
-        @include back-link;
-        z-index: 1002;
-      }
+      .exit-off-canvas { @include back-link; }
     }
 
     // Older browsers