]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
Ensure that the validate function returns the full list of validations to properly... 6241/head
authorNick Hammond <nick@nickhammond.com>
Fri, 30 Jan 2015 22:42:00 +0000 (16:42 -0600)
committerNick Hammond <nick@nickhammond.com>
Fri, 30 Jan 2015 22:42:00 +0000 (16:42 -0600)
js/foundation/foundation.abide.js
spec/abide/abide.js
spec/abide/basic.html

index 517e97a2d50e9df0e71f31204e08c78802a5f9e8..58997faf63e29ef62a329d4b83db701440536b4b 100644 (file)
         }
         validations.push(el_validations[0]);
       }
-      validations = [validations.every(function (valid) {return valid;})];
       return validations;
     },
 
index 56adc1ad7ba2d55dce0c0be74ddbb7f58f6e7f4b..05564ad4821651a4a5e0faef1716f6aa3187d5ac 100644 (file)
@@ -102,6 +102,20 @@ describe('abide:', function() {
       expect($('input[name="user_name"]')).not.toHaveData('invalid');
     });
 
+    it('should not focus hidden fields that are not required', function() {
+      $(document).foundation();
+      hidden_element = 'input[name="utf8"]';
+      first_element = 'input[name="user_name"]';
+
+      spyOnEvent(hidden_element, 'focus');
+      spyOnEvent(first_element, 'focus');
+
+      $('form').submit();
+
+      expect('focus').not.toHaveBeenTriggeredOn(hidden_element);
+      expect('focus').toHaveBeenTriggeredOn(first_element);
+    });
+
   });
 
   describe('advanced validation', function() {
index 5000841ffaa361fa8296fcff85f1ee2ae82cd562..8b360e7ad39fd2e192166e20fd11190de5523060 100644 (file)
@@ -1,4 +1,5 @@
 <form data-abide="ajax">
+  <input name="utf8" type="hidden" value="&#x2713;" />
   <div class="name-field">
     <label>Your name <small>required</small></label>
     <input name="user_name" type="text" required pattern="[a-zA-Z]+">