From: Rafael J. Wysocki Date: Mon, 1 Jun 2026 17:00:00 +0000 (+0200) Subject: ACPI: button: Change return type of two functions to void X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=06bc0064ad53be6b8f13b166b2fccbebe9eb6735;p=thirdparty%2Fkernel%2Flinux.git ACPI: button: Change return type of two functions to void The return value of acpi_lid_notify_state() is always 0, so change its return type to void. Moreover, the return value of the only caller of that function, acpi_lid_update_state(), is never used, so change its return type to void either. No intentional functional impact. Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/3429748.44csPzL39Z@rafael.j.wysocki --- diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index ae97c83bae2cd..fcb2eed823c15 100644 --- a/drivers/acpi/button.c +++ b/drivers/acpi/button.c @@ -204,7 +204,7 @@ static int acpi_lid_evaluate_state(acpi_handle lid_handle) return !!lid_state; } -static int acpi_lid_notify_state(struct acpi_button *button, bool state) +static void acpi_lid_notify_state(struct acpi_button *button, bool state) { struct acpi_device *device = button->adev; ktime_t next_report; @@ -282,8 +282,6 @@ static int acpi_lid_notify_state(struct acpi_button *button, bool state) button->last_state = state; button->last_time = ktime_get(); } - - return 0; } static int __maybe_unused acpi_button_state_seq_show(struct seq_file *seq, @@ -407,19 +405,18 @@ int acpi_lid_open(void) } EXPORT_SYMBOL(acpi_lid_open); -static int acpi_lid_update_state(struct acpi_button *button, - bool signal_wakeup) +static void acpi_lid_update_state(struct acpi_button *button, bool signal_wakeup) { int state; state = acpi_lid_evaluate_state(button->adev->handle); if (state < 0) - return state; + return; if (state && signal_wakeup) acpi_pm_wakeup_event(button->dev); - return acpi_lid_notify_state(button, state); + acpi_lid_notify_state(button, state); } static void acpi_lid_initialize_state(struct acpi_button *button)