From: Shane Lontis <shane.lontis@oracle.com>
Date: Mon, 24 Aug 2020 01:45:57 +0000 (+1000)
Subject: Fix coverity CID #1466375 - Remove dead code.
X-Git-Tag: openssl-3.0.0-alpha7~388
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=0e540f231cbdc8e24e1496cf8ac265b62a983692;p=thirdparty%2Fopenssl.git

Fix coverity CID #1466375 - Remove dead code.

Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
(Merged from https://github.com/openssl/openssl/pull/12708)
---

diff --git a/providers/implementations/encode_decode/encoder_ec.c b/providers/implementations/encode_decode/encoder_ec.c
index ee64e2f802d..ab8e82eb6ed 100644
--- a/providers/implementations/encode_decode/encoder_ec.c
+++ b/providers/implementations/encode_decode/encoder_ec.c
@@ -69,23 +69,20 @@ static int ossl_prov_print_ec_param_explicit_gen(BIO *out,
         || EC_POINT_point2bn(group, point, form, gen, ctx) == NULL)
         return 0;
 
-    if (gen != NULL) {
-        switch (form) {
-        case POINT_CONVERSION_COMPRESSED:
-           glabel = "Generator (compressed):";
-           break;
-        case POINT_CONVERSION_UNCOMPRESSED:
-            glabel = "Generator (uncompressed):";
-            break;
-        case POINT_CONVERSION_HYBRID:
-            glabel = "Generator (hybrid):";
-            break;
-        default:
-            return 0;
-        }
-        return ossl_prov_print_labeled_bignum(out, glabel, gen);
+    switch (form) {
+    case POINT_CONVERSION_COMPRESSED:
+       glabel = "Generator (compressed):";
+       break;
+    case POINT_CONVERSION_UNCOMPRESSED:
+        glabel = "Generator (uncompressed):";
+        break;
+    case POINT_CONVERSION_HYBRID:
+        glabel = "Generator (hybrid):";
+        break;
+    default:
+        return 0;
     }
-    return 1;
+    return ossl_prov_print_labeled_bignum(out, glabel, gen);
 }
 
 /* Print explicit parameters */