From: Lorenzo Bianconi Date: Wed, 3 Jun 2026 10:30:01 +0000 (+0200) Subject: net: airoha: Report extack error to the user if airoha_tc_htb_modify_queue() fails X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=144969cd80c5227c2b19fe5f644d6eebd61be586;p=thirdparty%2Flinux.git net: airoha: Report extack error to the user if airoha_tc_htb_modify_queue() fails Report an extack error message in airoha_tc_htb_modify_queue routine if airoha_qdma_set_tx_rate_limit() fails. Signed-off-by: Lorenzo Bianconi Reviewed-by: Alexander Lobakin Link: https://patch.msgid.link/20260603-airoha_tc_htb_modify_queue-err-message-v1-1-33ec3ab997d9@kernel.org Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c index 5474d4897110..584c4f1a09dc 100644 --- a/drivers/net/ethernet/airoha/airoha_eth.c +++ b/drivers/net/ethernet/airoha/airoha_eth.c @@ -2605,13 +2605,19 @@ static int airoha_tc_htb_modify_queue(struct net_device *dev, { u32 channel = TC_H_MIN(opt->classid) % AIROHA_NUM_QOS_CHANNELS; u32 rate = div_u64(opt->rate, 1000) << 3; /* kbps */ + int err; if (opt->parent_classid != TC_HTB_CLASSID_ROOT) { NL_SET_ERR_MSG_MOD(opt->extack, "invalid parent classid"); return -EINVAL; } - return airoha_qdma_set_tx_rate_limit(dev, channel, rate, opt->quantum); + err = airoha_qdma_set_tx_rate_limit(dev, channel, rate, opt->quantum); + if (err) + NL_SET_ERR_MSG_MOD(opt->extack, + "failed configuring htb offload"); + + return err; } static int airoha_tc_htb_alloc_leaf_queue(struct net_device *netdev,