From: Mark Andrews <marka@isc.org>
Date: Wed, 25 Sep 2013 22:25:09 +0000 (+1000)
Subject: 3657.   [port]          Some readline clones don't accept NULL pointers when
X-Git-Tag: v9.10.0a1~76
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=1a4725bef25e60de161f77318f362c327b690d72;p=thirdparty%2Fbind9.git

3657.   [port]          Some readline clones don't accept NULL pointers when
                        calling add_history. [RT #34842]
---

diff --git a/CHANGES b/CHANGES
index d350cf7b0a5..1fcfca1bed7 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+3657.	[port]		Some readline clones don't accept NULL pointers when
+			calling add_history. [RT #34842]
+
 3656.	[bug]		Treat a all zero netmask as invalid when generating
 			the localnets acl. [RT #34687]
 
diff --git a/bin/dig/nslookup.c b/bin/dig/nslookup.c
index d5ef50b7f6d..6c2f0a94998 100644
--- a/bin/dig/nslookup.c
+++ b/bin/dig/nslookup.c
@@ -776,7 +776,8 @@ get_next_command(void) {
 	if (interactive) {
 #ifdef HAVE_READLINE
 		ptr = readline("> ");
-		add_history(ptr);
+		if (ptr != NULL)
+			add_history(ptr);
 #else
 		fputs("> ", stderr);
 		fflush(stderr);
diff --git a/bin/nsupdate/nsupdate.c b/bin/nsupdate/nsupdate.c
index ddb7d446e28..486c1023250 100644
--- a/bin/nsupdate/nsupdate.c
+++ b/bin/nsupdate/nsupdate.c
@@ -2035,7 +2035,8 @@ get_next_command(void) {
 	if (interactive) {
 #ifdef HAVE_READLINE
 		cmdline = readline("> ");
-		add_history(cmdline);
+		if (cmdline != NULL)
+			add_history(cmdline);
 #else
 		fprintf(stdout, "> ");
 		fflush(stdout);