From: Michal Nowak Date: Mon, 1 Jun 2026 12:30:23 +0000 (+0000) Subject: Increase timeout for reload-based kasp signing checks X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=1b2d92be14068f1466add034466543e7e8e7075c;p=thirdparty%2Fbind9.git Increase timeout for reload-based kasp signing checks After reloading an inline-signed zone from file, named must re-read it, detect the deltas and generate RRSIGs before the answer is signed, which can take longer than 5 seconds on a loaded CI host and cause spurious update_is_signed() timeouts. Bump these reload-based checks to 10 seconds, matching cb_ixfr_is_signed. Assisted-by: Claude:claude-opus-4-8 (cherry picked from commit a2ccc04ae3fddd1786f7ac8f1b6fc637d818a190) --- diff --git a/bin/tests/system/kasp/tests_kasp.py b/bin/tests/system/kasp/tests_kasp.py index 7abfed33b2..13b711b283 100644 --- a/bin/tests/system/kasp/tests_kasp.py +++ b/bin/tests/system/kasp/tests_kasp.py @@ -907,7 +907,7 @@ def test_kasp_default(ns3): expected_updates = [f"a.{zone}. A 10.0.0.11", f"d.{zone}. A 10.0.0.44"] for update in expected_updates: - isctest.run.retry_with_timeout(update_is_signed, timeout=5) + isctest.run.retry_with_timeout(update_is_signed, timeout=10) # Move the private key file, a rekey event should not introduce # replacement keys. @@ -1007,7 +1007,7 @@ def test_kasp_dynamic(ns3): expected_updates = [f"a.{zone}. A 10.0.0.1", f"d.{zone}. A 10.0.0.44"] for update in expected_updates: - isctest.run.retry_with_timeout(update_is_signed, timeout=5) + isctest.run.retry_with_timeout(update_is_signed, timeout=10) # Dynamic, and inline-signing. zone = "dynamic-inline-signing.kasp" @@ -1043,7 +1043,7 @@ def test_kasp_dynamic(ns3): expected_updates = [f"a.{zone}. A 10.0.0.11", f"d.{zone}. A 10.0.0.44"] for update in expected_updates: - isctest.run.retry_with_timeout(update_is_signed, timeout=5) + isctest.run.retry_with_timeout(update_is_signed, timeout=10) # Dynamic, signed, and inline-signing. isctest.log.info("check dynamic signed, and inline-signed zone")