From: Petr Vaganov <petrvaganoff@gmail.com>
Date: Thu, 23 Jul 2026 08:22:02 +0000 (+0700)
Subject: pythonmod: add check return value after ftell() (#1478)
X-Git-Tag: release-1.26.0rc1~22
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=1bab2dfafa7e7cc6b016b9854a4ff5f1d9af1b50;p=thirdparty%2Funbound.git

pythonmod: add check return value after ftell() (#1478)

Variable 'flen', which might receive a negative value at pythonmod.c:493
by calling function 'ftell', is used without checking at pythonmod.c:508
by calling function 'fread'.

Found by the static analyzer Svace (ISP RAS).

Signed-off-by: Petr Vaganov <petrvaganoff@gmail.com>
---

diff --git a/pythonmod/pythonmod.c b/pythonmod/pythonmod.c
index 1b077bb6f..045dd1bbd 100644
--- a/pythonmod/pythonmod.c
+++ b/pythonmod/pythonmod.c
@@ -487,10 +487,17 @@ int pythonmod_init(struct module_env* env, int id)
       /* for python 3.9 and newer */
       char* fstr = NULL;
       size_t flen = 0;
+      long pos = 0;
       log_err("pythonmod: can't parse Python script %s", pe->fname);
       /* print the error to logs too, run it again */
       fseek(script_py, 0, SEEK_END);
-      flen = (size_t)ftell(script_py);
+      pos = ftell(script_py);
+      if (pos == -1L) {
+         log_err("ftell failed to print parse error: %s: %s",
+            pe->fname, strerror(errno));
+         goto fail_close_file;
+      }
+      flen = (size_t)pos;
 #ifdef SIZE_MAX
       if(flen > SIZE_MAX-2) {
 		log_err("script file too large");