From: Takashi Iwai <tiwai@suse.de>
Date: Thu, 23 Apr 2026 07:52:05 +0000 (+0200)
Subject: Revert "ALSA: pcmtest: fix reference leak on failed device registration"
X-Git-Tag: v7.1-rc1~22^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=2724fbc90e5c133fbbd030e72fe8a3869a20df08;p=thirdparty%2Flinux.git

Revert "ALSA: pcmtest: fix reference leak on failed device registration"

We'd like to address the problem rather in the error code path of
platform_device_register() itself instead of leaving it all callers,
since less than 1% of all callers of over 100
platform_device_register() do call platform_device_put() properly as
of now.

For making the work easier, revert the previous change commit
4ff036f95238 ("ALSA: pcmtest: fix reference leak on failed device
registration") again.

Link: https://lore.kernel.org/20260415193138.3861297-1-lgs201920130244@gmail.com
Link: https://patch.msgid.link/20260423075211.3977366-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
index fe31ff1e5b3c..5bfec4c7bf71 100644
--- a/sound/drivers/pcmtest.c
+++ b/sound/drivers/pcmtest.c
@@ -756,10 +756,8 @@ static int __init mod_init(void)
 	if (err)
 		goto err_free_patterns;
 	err = platform_device_register(&pcmtst_pdev);
-	if (err) {
-		platform_device_put(&pcmtst_pdev);
+	if (err)
 		goto err_clear_debug;
-	}
 	err = platform_driver_register(&pcmtst_pdrv);
 	if (err) {
 		platform_device_unregister(&pcmtst_pdev);