From: Mark Andrews <marka@isc.org>
Date: Wed, 21 Sep 2022 01:54:48 +0000 (+1000)
Subject: Stop passing mctx to dns_rdata_tostruct as it is unnecessary for SIG
X-Git-Tag: v9.16.34~17^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=2905d70ad1ab370e79aec32b1df41e57af41039a;p=thirdparty%2Fbind9.git

Stop passing mctx to dns_rdata_tostruct as it is unnecessary for SIG

dns_rdata_tostruct doesn't need a mctx passed to it for SIG (the signer
is already expanded at this point). About the only time when mctx is
needed is when the structure is to be used after the rdata has been
destroyed.

(cherry picked from commit d6ad56bd9e98382f8bd41a25756efdbbc3e39bd9)
---

diff --git a/lib/dns/message.c b/lib/dns/message.c
index 7b3d72abd97..05aaf03090f 100644
--- a/lib/dns/message.c
+++ b/lib/dns/message.c
@@ -3220,7 +3220,7 @@ dns_message_checksig(dns_message_t *msg, dns_view_t *view) {
 			return (ISC_R_UNEXPECTEDEND);
 		}
 
-		result = dns_rdata_tostruct(&rdata, &sig, msg->mctx);
+		result = dns_rdata_tostruct(&rdata, &sig, NULL);
 		if (result != ISC_R_SUCCESS) {
 			return (result);
 		}