From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 11 Apr 2024 04:17:23 +0000 (+1200)
Subject: ldb-samba:ldif_handlers: extended_dn_read_Sid(): free on failure
X-Git-Tag: tdb-1.4.11~1025
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=2d3b917d0a078279853bb3926b7dc3584fe53627;p=thirdparty%2Fsamba.git

ldb-samba:ldif_handlers: extended_dn_read_Sid(): free on failure

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb-samba/ldif_handlers.c b/lib/ldb-samba/ldif_handlers.c
index f3187731bc6..492f42077bd 100644
--- a/lib/ldb-samba/ldif_handlers.c
+++ b/lib/ldb-samba/ldif_handlers.c
@@ -235,6 +235,7 @@ static int extended_dn_read_SID(struct ldb_context *ldb, void *mem_ctx,
 	ndr_err = ndr_pull_struct_blob_all_noalloc(out, &sid,
 					   (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
 	if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+		TALLOC_FREE(out->data);
 		return -1;
 	}
 	return 0;