From: Mark Andrews <marka@isc.org>
Date: Thu, 4 Oct 2012 20:57:05 +0000 (+1000)
Subject: 3389.   [bug]           Always return NOERROR (not 0) in TSIG. [RT #31275]
X-Git-Tag: v9.10.0a1~821
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=2ec7373254331f183ae62a13acbac24c80a6a3aa;p=thirdparty%2Fbind9.git

3389.   [bug]           Always return NOERROR (not 0) in TSIG. [RT #31275]
---

diff --git a/CHANGES b/CHANGES
index e7d71ce5f0e..2178b6a80f0 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+3389.	[bug]		Always return NOERROR (not 0) in TSIG. [RT #31275]
+
 3388.	[bug]		Fixed several Coverity warnings. [RT #30996]
 
 3387.	[func]		DS digest can be disabled at runtime with
diff --git a/lib/dns/rdata/any_255/tsig_250.c b/lib/dns/rdata/any_255/tsig_250.c
index 3691121ddc8..1d0a836bfa8 100644
--- a/lib/dns/rdata/any_255/tsig_250.c
+++ b/lib/dns/rdata/any_255/tsig_250.c
@@ -226,12 +226,7 @@ totext_any_tsig(ARGS_TOTEXT) {
 	 */
 	n = uint16_fromregion(&sr);
 	isc_region_consume(&sr, 2);
-	if (dns_tsigrcode_totext((dns_rcode_t)n, target) == ISC_R_SUCCESS)
-		RETERR(str_totext(" ", target));
-	else {
-		sprintf(buf, "%u ", n);
-		RETERR(str_totext(buf, target));
-	}
+	RETERR(dns_tsigrcode_totext((dns_rcode_t)n, target));
 
 	/*
 	 * Other Size.