From: Ondřej Surý <ondrej@isc.org>
Date: Thu, 27 Jul 2023 09:31:06 +0000 (+0200)
Subject: Free struct stub_glue_request in stub_glue_response() callback
X-Git-Tag: v9.19.16~20^2~1
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=31c43d4b76b11e99d667dd035a85b716762e40a8;p=thirdparty%2Fbind9.git

Free struct stub_glue_request in stub_glue_response() callback

When stub_glue_response() is called, the associated data is stored in
newly allocated struct stub_glue_request.  The allocated structure is
never freed in the callback, thus we leak a little bit of memory.
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index dfbdb66040d..e499444a936 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -12880,6 +12880,7 @@ cleanup:
 	}
 	dns_name_free(&sgr->name, zone->mctx);
 	dns_request_destroy(&request);
+	isc_mem_put(zone->mctx, sgr, sizeof(*sgr));
 
 	/* If last request, release all related resources */
 	if (atomic_fetch_sub_release(&stub->pending_requests, 1) == 1) {