From: Ralph Dolmans <ralph@nlnetlabs.nl>
Date: Wed, 26 Apr 2017 13:27:07 +0000 (+0000)
Subject: please lint
X-Git-Tag: release-1.6.4rc1~99
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=33001c8c4bffae144080c6234e23552338a974e2;p=thirdparty%2Funbound.git

please lint


git-svn-id: file:///svn/unbound/trunk@4135 be551aaa-1e26-0410-a405-d3ace91eadb9
---

diff --git a/validator/validator.c b/validator/validator.c
index a9ab1fda5..06edf64ca 100644
--- a/validator/validator.c
+++ b/validator/validator.c
@@ -457,6 +457,7 @@ generate_keytag_query(struct module_qstate* qstate, int id,
 	size_t i, numtag;
 	uint16_t tags[MAX_LABEL_TAGS];
 	char tagstr[LDNS_MAX_LABELLEN+1] = "_ta"; /* +1 for NULL byte */
+	size_t tagstr_left = sizeof(tagstr) - strlen(tagstr);
 	char* tagstr_pos = tagstr + strlen(tagstr);
 	uint8_t dnamebuf[LDNS_MAX_DOMAINLEN+1]; /* +1 for label length byte */
 	size_t dnamebuf_len = sizeof(dnamebuf);
@@ -469,10 +470,10 @@ generate_keytag_query(struct module_qstate* qstate, int id,
 	for(i=0; i<numtag; i++) {
 		/* Buffer can't overflow; numtag is limited to tags that fit in
 		 * the buffer. */
-		sprintf(tagstr_pos, "-%04x", (unsigned)tags[i]);
+		snprintf(tagstr_pos, tagstr_left, "-%04x", (unsigned)tags[i]);
+		tagstr_left -= strlen(tagstr_pos);
 		tagstr_pos += strlen(tagstr_pos);
 	}
-	*tagstr_pos = '\0';
 
 	sldns_str2wire_dname_buf_origin(tagstr, dnamebuf, &dnamebuf_len,
 		ta->name, ta->namelen);