From: Mark Andrews <marka@isc.org>
Date: Wed, 5 Dec 2012 00:43:07 +0000 (+1100)
Subject: silence clang --analyser false positive
X-Git-Tag: v9.10.0a1~679^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=377e7f19ef4789144bd1d69421360d5aa7e04b83;p=thirdparty%2Fbind9.git

silence clang --analyser false positive
---

diff --git a/bin/tests/names/t_names.c b/bin/tests/names/t_names.c
index 5271d8929fd..a0b3f89de1d 100644
--- a/bin/tests/names/t_names.c
+++ b/bin/tests/names/t_names.c
@@ -2194,7 +2194,8 @@ static const char *a52 =
 
 static int
 test_dns_name_towire(char *testname, unsigned int dc_method, char *exp_data,
-		     int exp_data_len, isc_result_t exp_result, size_t buflen)
+		     size_t exp_data_len, isc_result_t exp_result,
+		     size_t buflen)
 {
 	int			result;
 	int			val;
@@ -2263,6 +2264,7 @@ t_dns_name_towire_x(const char *testfile, size_t buflen) {
 	int		result;
 	unsigned int	dc_method;
 	isc_result_t	exp_result;
+	size_t		exp_data_len;
 	char		*p;
 	FILE		*fp;
 
@@ -2292,11 +2294,12 @@ t_dns_name_towire_x(const char *testfile, size_t buflen) {
 
 				dc_method = t_dc_method_fromtext(Tokens[3]);
 				exp_result = t_dns_result_fromtext(Tokens[4]);
+				exp_data_len = strtoul(Tokens[3], NULL, 10);
 
 				result = test_dns_name_towire(Tokens[0],
 							      dc_method,
 							      Tokens[2],
-							      atoi(Tokens[3]),
+							      exp_data_len,
 							      exp_result,
 							      buflen);
 			} else {