From: Ondřej Surý <ondrej@sury.org>
Date: Mon, 4 Oct 2021 15:14:53 +0000 (+0200)
Subject: Change the ISC_R_SUCCESS to DNS_RRL_RESULT_OK in dns_rrl()
X-Git-Tag: v9.17.19~8^2~3
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=4d85040df5baab2dfb850af2a110f30e840bc9a2;p=thirdparty%2Fbind9.git

Change the ISC_R_SUCCESS to DNS_RRL_RESULT_OK in dns_rrl()

There's value mismatch between the return type of dns_rrl() that's
dns_rrl_result_t and ISC_R_SUCCESS which belongs to isc_result_t.  This
works incidentally, because DNS_RRL_RESULT_OK == ISC_R_SUCCESS.

This would break when we change isc_result_t to be static enum in
consecutive commit.  Change the value to match the type.
---

diff --git a/lib/dns/rrl.c b/lib/dns/rrl.c
index 9c009b2fdc2..758bb1ed8d7 100644
--- a/lib/dns/rrl.c
+++ b/lib/dns/rrl.c
@@ -1113,7 +1113,7 @@ dns_rrl(dns_view_t *view, const isc_sockaddr_t *client_addr, bool is_tcp,
 			}
 		}
 		UNLOCK(&rrl->lock);
-		return (ISC_R_SUCCESS);
+		return (DNS_RRL_RESULT_OK);
 	}
 
 	/*