From: Michal Nowak <mnowak@isc.org>
Date: Tue, 30 Nov 2021 12:52:49 +0000 (+0100)
Subject: Drop cppcheck CI job
X-Git-Tag: v9.16.25~26^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=4f5d0ea1a2585cf003b2cb370095e049c195a551;p=thirdparty%2Fbind9.git

Drop cppcheck CI job

Every cppcheck update brings the cost of addressing new false positives
in the BIND 9 source code while not reaping any benefits in case of
identified issues with the code.

(cherry picked from commit 654cc61bb93da031c599488102fe162d09b87fc7)
---

diff --git a/.gitignore b/.gitignore
index c6b8ee52eed..7ef6b86d137 100644
--- a/.gitignore
+++ b/.gitignore
@@ -59,7 +59,5 @@ named.memstats
 named.run
 timestamp
 /compile_commands.json
-/cppcheck_html/
-/cppcheck.results
 /tsan
 /util/check-make-install
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 58be57c6259..5a0d61fbbde 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -406,34 +406,6 @@ stages:
       - kyua_html/
     when: on_failure
 
-.cppcheck_args: &run_cppcheck
-  - cppcheck --enable=warning,performance,portability,information,missingInclude --include=config.h --std=c11 --language=c --project=compile_commands.json --error-exitcode=2 -j ${TEST_PARALLEL_JOBS:-1} --xml --output-file=cppcheck.results --relative-paths="$CI_PROJECT_DIR" --inline-suppr --suppressions-list=util/suppressions.txt
-
-.cppcheck_report: &cppcheck_report_html
-  - cppcheck-htmlreport --title="BIND 9 ($CI_COMMIT_SHORT_SHA) Cppcheck Report" --file=cppcheck.results --report-dir=cppcheck_html/
-
-.cppcheck: &cppcheck_job
-  <<: *default_triggering_rules
-  stage: postcheck
-  script:
-    - *configure
-    - (make -nwk all || true) | compiledb
-    - export GCC_VERSION=$(gcc --version | sed -n 's/.* \([0-9]\+\)\.[0-9]\+\.[0-9]\+.*/\1/p')
-    - sed -i "/gcc\",/a\"-DCPPCHECK\", \"-D__STDC__\", \"-D__GNUC__=${GCC_VERSION}\"," compile_commands.json
-    - *run_cppcheck
-  after_script:
-    - *cppcheck_report_html
-  artifacts:
-    paths:
-      - compile_commands.json
-      - cppcheck.results
-      - cppcheck_html/
-    expire_in: "1 day"
-    when: on_failure
-  needs:
-    - job: autoreconf
-      artifacts: true
-
 ### Job Definitions
 
 # Jobs in the precheck stage
@@ -818,10 +790,6 @@ unit:gcc:sid:amd64:
     - job: gcc:sid:amd64
       artifacts: true
 
-cppcheck:
-  <<: *base_image
-  <<: *cppcheck_job
-
 # Job for out-of-tree GCC build on Debian "sid" (amd64)
 # Also tests configration option: --with-lmdb.