From: Matthijs Mekking <matthijs@isc.org>
Date: Thu, 1 Feb 2024 15:33:21 +0000 (+0100)
Subject: Update autosign test to use signatures-jitter
X-Git-Tag: v9.19.24~28^2~4
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=50bd729019c5ac30f3bfef6cbd153537f9520782;p=thirdparty%2Fbind9.git

Update autosign test to use signatures-jitter

Now that we have an option to configure jitter, use it in system tests
that test jitter.
---

diff --git a/bin/tests/system/autosign/ns3/named.conf.in b/bin/tests/system/autosign/ns3/named.conf.in
index 9bc5d655e16..2316de29326 100644
--- a/bin/tests/system/autosign/ns3/named.conf.in
+++ b/bin/tests/system/autosign/ns3/named.conf.in
@@ -87,6 +87,7 @@ dnssec-policy "jitter" {
 	signatures-validity P10D;
 	signatures-validity-dnskey P10D;
 	signatures-refresh P2D;
+	signatures-jitter P8D;
 };
 
 # Jitter, NSEC3
diff --git a/bin/tests/system/autosign/tests.sh b/bin/tests/system/autosign/tests.sh
index 1839738966b..3b7613226dd 100755
--- a/bin/tests/system/autosign/tests.sh
+++ b/bin/tests/system/autosign/tests.sh
@@ -91,10 +91,10 @@ checkjitter() {
 
   _count=0
   # Check if we have at least 4 days
-  # This number has been tuned for `signatures-validity 10d; signatures-refresh 2d`, as
-  # 1 signature expiration dates should be spread out across at most 8 (10-2) days
-  # 2. we remove first and last day to remove frequency outlier, we are left with 6 (8-2) days
-  # 3. we subtract two more days to allow test pass on day boundaries, etc. leaving us with 4 (6-2)
+  # This number has been tuned for `signatures-validity 10d; signatures-jitter 8d`, as
+  # 1. signature expiration dates should be spread out across at most 8 days
+  # 2. we remove first and last day to remove frequency outlier, we are left with 6 days
+  # 3. we subtract two more days to allow test pass on day boundaries, etc. leaving us with 4 days
   for _num in $_expiretimes; do
     _count=$((_count + 1))
   done