From: Michał Kępień <michal@isc.org>
Date: Tue, 12 Oct 2021 08:44:30 +0000 (+0200)
Subject: Properly handle JEMALLOC_* Autoconf variables
X-Git-Tag: v9.17.20~61^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=5178ba4cf2bf2a69b187dd4af23ef2cdf2169281;p=thirdparty%2Fbind9.git

Properly handle JEMALLOC_* Autoconf variables

The AX_CHECK_JEMALLOC() m4 macro sets the JEMALLOC_CFLAGS variable, not
JEMALLOC_CPPFLAGS.  Furthermore, the JEMALLOC_CFLAGS and JEMALLOC_LIBS
variables should only be included in the build flags if jemalloc was
successfully configured.  Tweak lib/isc/Makefile.am accordingly.
---

diff --git a/configure.ac b/configure.ac
index e68e78b1cc7..543ed9ba195 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1338,6 +1338,8 @@ AS_CASE([$with_jemalloc],
 AS_IF([test "$with_jemalloc" = "no"],
       [AC_CHECK_FUNCS([malloc_size malloc_usable_size])])
 
+AM_CONDITIONAL([HAVE_JEMALLOC], [test "$with_jemalloc" = "yes"])
+
 #
 # was --with-tuning specified?
 #
diff --git a/lib/isc/Makefile.am b/lib/isc/Makefile.am
index 521ed9e2667..3ee7cc2fa98 100644
--- a/lib/isc/Makefile.am
+++ b/lib/isc/Makefile.am
@@ -212,7 +212,6 @@ libisc_la_SOURCES =		\
 
 libisc_la_CPPFLAGS =		\
 	$(AM_CPPFLAGS)		\
-	$(JEMALLOC_CPPFLAGS)	\
 	$(LIBISC_CFLAGS)	\
 	$(LIBUV_CFLAGS)		\
 	$(OPENSSL_CFLAGS)	\
@@ -223,22 +222,17 @@ libisc_la_LDFLAGS =		\
 	-release "$(PACKAGE_VERSION)"
 
 libisc_la_LIBADD =		\
-	$(JEMALLOC_LIBS)	\
 	$(LIBUV_LIBS)		\
 	$(OPENSSL_LIBS)		\
 	$(ZLIB_LIBS)
 
-if HAVE_LIBNGHTTP2
-libisc_la_SOURCES +=		\
-	netmgr/http.c		\
-	netmgr/tlsstream.c
-
+if HAVE_JEMALLOC
 libisc_la_CPPFLAGS +=		\
-	$(LIBNGHTTP2_CFLAGS)
+	$(JEMALLOC_CFLAGS)
 
 libisc_la_LIBADD +=		\
-	$(LIBNGHTTP2_LIBS)
-endif
+	$(JEMALLOC_LIBS)
+endif HAVE_JEMALLOC
 
 if HAVE_JSON_C
 libisc_la_CPPFLAGS +=		\
@@ -248,6 +242,18 @@ libisc_la_LIBADD +=		\
 	$(JSON_C_LIBS)
 endif HAVE_JSON_C
 
+if HAVE_LIBNGHTTP2
+libisc_la_SOURCES +=		\
+	netmgr/http.c		\
+	netmgr/tlsstream.c
+
+libisc_la_CPPFLAGS +=		\
+	$(LIBNGHTTP2_CFLAGS)
+
+libisc_la_LIBADD +=		\
+	$(LIBNGHTTP2_LIBS)
+endif
+
 if HAVE_LIBXML2
 libisc_la_CPPFLAGS +=		\
 	$(LIBXML2_CFLAGS)