From: Andrew Pinski Date: Sun, 15 Mar 2026 06:36:56 +0000 (-0700) Subject: c++: Fix ICE with error mark for an attribute [PR124307] X-Git-Tag: basepoints/gcc-17~685 X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=57ccf065094f74d8c87d8a4cdc495d4195d70d65;p=thirdparty%2Fgcc.git c++: Fix ICE with error mark for an attribute [PR124307] After r16-6808-g4b0e94b394fa38, we started to ICE when the std_attrs was error_mark_node. This fixes the problem by checking if it was an error_mark_node before looking for annotations. Bootstrapped and tested on x86_64-linux-gnu with no regressions. Changes since v1: * v2: Move the check for error mark earlier. * v3: small formating changes. PR c++/124307 gcc/cp/ChangeLog: * parser.cc (cp_parser_base_specifier): Check for error mark like checking for non-nullness on the attribute. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/alignas24.C: New test. Signed-off-by: Andrew Pinski --- diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc index ffb22aa776f..51d26cecc4b 100644 --- a/gcc/cp/parser.cc +++ b/gcc/cp/parser.cc @@ -31830,7 +31830,7 @@ cp_parser_base_specifier (cp_parser* parser) tree std_attrs = cp_parser_std_attribute_spec_seq (parser); tree annotations = NULL_TREE; - if (std_attrs != NULL_TREE) + if (std_attrs != NULL_TREE && std_attrs != error_mark_node) { tree *pannotations = &annotations; for (tree attr = std_attrs; attr; attr = TREE_CHAIN (attr)) diff --git a/gcc/testsuite/g++.dg/cpp0x/alignas24.C b/gcc/testsuite/g++.dg/cpp0x/alignas24.C new file mode 100644 index 00000000000..2966a9c2aa3 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/alignas24.C @@ -0,0 +1,5 @@ +// PR c++/124307 +// { dg-do compile { target c++11 } } +// { dg-options "" } + +class : alignas // { dg-error "" }