From: Mark Andrews <marka@isc.org>
Date: Wed, 9 Sep 2020 00:40:14 +0000 (+1000)
Subject: Silence REVERSE_INULL warning (CID 306652)
X-Git-Tag: v9.17.6~67^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=584dbffab1fb855f3b41df32cc258cc5c7969369;p=thirdparty%2Fbind9.git

Silence REVERSE_INULL warning (CID 306652)
---

diff --git a/lib/isc/unix/socket.c b/lib/isc/unix/socket.c
index a7e6804615d..768add0940e 100644
--- a/lib/isc/unix/socket.c
+++ b/lib/isc/unix/socket.c
@@ -3771,13 +3771,11 @@ cleanup_thread(isc_mem_t *mctx, isc__socketthread_t *thread) {
 	isc_mem_put(thread->manager->mctx, thread->fdstate,
 		    thread->manager->maxsocks * sizeof(int));
 
-	if (thread->fdlock != NULL) {
-		for (i = 0; i < FDLOCK_COUNT; i++) {
-			isc_mutex_destroy(&thread->fdlock[i]);
-		}
-		isc_mem_put(thread->manager->mctx, thread->fdlock,
-			    FDLOCK_COUNT * sizeof(isc_mutex_t));
+	for (i = 0; i < FDLOCK_COUNT; i++) {
+		isc_mutex_destroy(&thread->fdlock[i]);
 	}
+	isc_mem_put(thread->manager->mctx, thread->fdlock,
+		    FDLOCK_COUNT * sizeof(isc_mutex_t));
 }
 
 isc_result_t