From: John Garry Date: Wed, 13 May 2026 09:50:30 +0000 (+0000) Subject: nvme: use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE for multipath_sysfs X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=5ab7c84f218b08908bf7768e5669d15e89595a02;p=thirdparty%2Fkernel%2Flinux.git nvme: use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE for multipath_sysfs Use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE instead of DEFINE_SYSFS_GROUP_VISIBLE, which means that we can drop multipath_sysfs_attr_visible(). Incidentally, multipath_sysfs_attr_visible() should have returned a umode_t. This idea was suggested by Ben Marzinski elsewhere. Reviewed-by: Christoph Hellwig Signed-off-by: John Garry Signed-off-by: Keith Busch --- diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c index b682c1a4b23f9..1f471f2cfd251 100644 --- a/drivers/nvme/host/sysfs.c +++ b/drivers/nvme/host/sysfs.c @@ -335,14 +335,7 @@ static bool multipath_sysfs_group_visible(struct kobject *kobj) return nvme_disk_is_ns_head(dev_to_disk(dev)); } - -static bool multipath_sysfs_attr_visible(struct kobject *kobj, - struct attribute *attr, int n) -{ - return false; -} - -DEFINE_SYSFS_GROUP_VISIBLE(multipath_sysfs) +DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(multipath_sysfs) const struct attribute_group nvme_ns_mpath_attr_group = { .name = "multipath",