From: Tony Finch <fanf@isc.org>
Date: Wed, 10 May 2023 16:15:21 +0000 (+0100)
Subject: Avoid lossage from <stdnoreturn.h>
X-Git-Tag: v9.19.14~62^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=623f2fdb18d4aa1ebcb087cf78ef9956ac584ed6;p=thirdparty%2Fbind9.git

Avoid lossage from <stdnoreturn.h>

A few of the source files in `tests/ns` included `<isc/util.h>`
before `<cmocka.h>`. This could cause compile failures because the
`CMOCKA_NORETURN` macro is defined as `__attribute__((noreturn))`
and `<stdnoreturn.h>` defines `noreturn` as `_Noreturn` which does
not work as a gcc-style attribute.
---

diff --git a/tests/ns/listenlist_test.c b/tests/ns/listenlist_test.c
index a7ddcf828a3..35ac84f15cf 100644
--- a/tests/ns/listenlist_test.c
+++ b/tests/ns/listenlist_test.c
@@ -20,13 +20,12 @@
 #include <string.h>
 #include <unistd.h>
 
-#include <isc/util.h>
-
 #define UNIT_TESTING
 #include <cmocka.h>
 
 #include <isc/list.h>
 #include <isc/random.h>
+#include <isc/util.h>
 
 #include <dns/acl.h>
 
diff --git a/tests/ns/notify_test.c b/tests/ns/notify_test.c
index 615cb57a25e..1410f6d1484 100644
--- a/tests/ns/notify_test.c
+++ b/tests/ns/notify_test.c
@@ -20,12 +20,11 @@
 #include <string.h>
 #include <unistd.h>
 
-#include <isc/util.h>
-
 #define UNIT_TESTING
 #include <cmocka.h>
 
 #include <isc/thread.h>
+#include <isc/util.h>
 
 #include <dns/acl.h>
 #include <dns/rcode.h>
diff --git a/tests/ns/query_test.c b/tests/ns/query_test.c
index 6dcf5f102fb..adfcc031007 100644
--- a/tests/ns/query_test.c
+++ b/tests/ns/query_test.c
@@ -20,12 +20,11 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include <isc/util.h>
-
 #define UNIT_TESTING
 #include <cmocka.h>
 
 #include <isc/quota.h>
+#include <isc/util.h>
 
 #include <dns/badcache.h>
 #include <dns/view.h>