From: Michal Nowak <mnowak@isc.org>
Date: Thu, 9 Mar 2023 10:10:53 +0000 (+0100)
Subject: Drop parallel build from stress tests
X-Git-Tag: v9.16.40~26^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=70f23b7ddef4b660fd93cd8fe358226731dae2a0;p=thirdparty%2Fbind9.git

Drop parallel build from stress tests

BUILD_PARALLEL_JOBS environmental variable is set to 6, which does not
align well with 4 and 8 CPU core systems dedicated to CI "stress" tests.
When multiple parallel jobs run on the host, they compete for resources
with an undesirable result: 6 compiler processes of one job may starve
named, resulting in lower-than-expected throughput and minutes-long
query response latency spikes.

Better drop the build parallelism of BIND-under-test. About 1-2 minutes
are added to the 60-65 minutes long job duration.

(cherry picked from commit 3fd7e7c81f81e21adebde2930fe511fe335f825e)
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 0581a9628d0..2186c05d6d7 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1490,13 +1490,17 @@ respdiff-long-third-party:
 
 # "Stress" tests
 
+# Parallel build in the "make" step is avoided since multiple jobs can be
+# executed concurrently on the same runner. This may present problems when one
+# job runs a performance-sensitive task of replying to queries while another
+# takes all cores to build BIND.
 .stress: &stress_job
   stage: performance
   script:
     - *configure
     - *setup_interfaces
     - *setup_softhsm
-    - make -j${BUILD_PARALLEL_JOBS:-1} -k all V=1
+    - make -k all V=1
     - make DESTDIR="${INSTALL_PATH}" install
     - git clone --depth 1 https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.isc.org/isc-private/bind-qa.git
     - cd bind-qa/bind9/stress