From: Michael R Sweet Date: Wed, 22 Apr 2026 19:04:07 +0000 (-0400) Subject: Add missing value tag test to cupsCheckDestSupported. X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=7484e4824ac6c0109428eb17c3aa9970caa8a856;p=thirdparty%2Fcups.git Add missing value tag test to cupsCheckDestSupported. --- diff --git a/CHANGES.md b/CHANGES.md index 396cee34e2..e2e24f4743 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -172,6 +172,7 @@ v2.5b1 - YYYY-MM-DD - Fixed A4 support in the `ippevepcl` program (Issue #1544) - Fixed issues with the environment variable support of CGI programs (Issue #1547) +- Fixed potential crash bug in `cupsCheckDestSupported` function. - Removed hash support for SHA2-512-224 and SHA2-512-256. - Removed `mantohtml` script for generating html pages (use `https://www.msweet.org/mantohtml/`) diff --git a/cups/dest-options.c b/cups/dest-options.c index 5c8464ccc3..892b595781 100644 --- a/cups/dest-options.c +++ b/cups/dest-options.c @@ -304,7 +304,7 @@ cupsCheckDestSupported( * Compare values... */ - if (!strcmp(option, "media") && !strncmp(value, "custom_", 7)) + if (!strcmp(option, "media") && (ippGetValueTag(attr) == IPP_TAG_KEYWORD || ippGetValueTag(attr) == IPP_TAG_NAME || ippGetValueTag(attr) == IPP_TAG_NAMELANG) && !strncmp(value, "custom_", 7)) { /* * Check range of custom media sizes...