From: Matthijs Mekking <matthijs@isc.org>
Date: Fri, 4 Feb 2022 10:55:46 +0000 (+0100)
Subject: Fix keyfromlabel test, missing status update
X-Git-Tag: v9.19.0~128^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=7845f51178ba3ea0f68ab18c766c7255c710aed3;p=thirdparty%2Fbind9.git

Fix keyfromlabel test, missing status update

Fix a missing status=$((status+ret)) in the keyfromlabel system test,
which would ignore the error if ZSK key creation failed.
---

diff --git a/bin/tests/system/keyfromlabel/tests.sh b/bin/tests/system/keyfromlabel/tests.sh
index 247eefe688b..4f6940af7b6 100644
--- a/bin/tests/system/keyfromlabel/tests.sh
+++ b/bin/tests/system/keyfromlabel/tests.sh
@@ -65,13 +65,14 @@ do
 		ret=0
 		zsk=$(keyfromlabel $alg $zone keyfromlabel-zsk)
 		test -z "$zsk" && ret=1
+		test "$ret" -eq 0 || echo_i "failed (zsk=$zsk)"
+		status=$((status+ret))
 
 		echo_i "Get KSK $alg $zone $type:$bits"
 		ret=0
 		ksk=$(keyfromlabel $alg $zone keyfromlabel-ksk -f KSK)
 		test -z "$ksk" && ret=1
-
-		test "$ret" -eq 0 || echo_i "failed (zsk=$zsk ksk=$ksk)"
+		test "$ret" -eq 0 || echo_i "failed (ksk=$ksk)"
 		status=$((status+ret))
 
 		# Skip signing if dnssec-keyfromlabel failed.